Bug 1810 – Symlinks to artcover is displayed in BMF

Bug 1810 - Symlinks to artcover is displayed in BMF

Summary:

Symlinks to artcover is displayed in BMF

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Formats
Version:	6.1.0
Platform:	PC Linux (other)

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-07-13 00:06 UTC by Michael Herger
Modified:	2008-08-18 10:54 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Check whether a symlink's target is a valid file type or folder (609 bytes, patch) 2005-07-13 01:52 UTC, Michael Herger	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Herger 2005-07-13 00:06:01 UTC

In BMF artwork files normally aren't listed. I sometimes put symlinks instead of those files in my folders, if it 
is a two disc album like eg.:

Superstar
   Singles Collection
      Disc1
         cover.jpg
      Disc2
         cover.jpg->../Disc1/cover.jpg

The links are treated like music files, displayed on the player and the web interface and could even be 
added to the playlist (it didn't play, though :-))

Comment 1 Michael Herger 2005-07-13 01:34:24 UTC

This was introduced with change 3519: we're accepting any symlink without checking the type of the 
target. Without that change, any symlink matching $validRE would be ignored, right? 

Checking for the target's type might be expensive, but most users won't have lots of links in their 
collection.

Comment 2 Michael Herger 2005-07-13 01:52:50 UTC

Created attachment 628 [details]
Check whether a symlink's target is a valid file type or folder

Comment 3 Blackketter Dean 2005-07-18 08:20:54 UTC

Looks reasonable.

Comment 4 Michael Herger 2005-07-18 08:34:26 UTC

Change 3730.

Comment 5 Chris Owens 2008-03-11 11:28:28 UTC

This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!