Bug 18052 - Setting the Rescan Timer is broken in ip3k interface - Patch attached
: Setting the Rescan Timer is broken in ip3k interface - Patch attached
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugin
: 7.7.2
: All All
: P4 normal (vote)
: 7.7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-06 17:34 UTC by Martin Williams
Modified: 2013-09-09 13:05 UTC (History)
1 user (show)

See Also:
Category: Bug


Attachments
Proposed patch (447 bytes, patch)
2013-09-06 17:34 UTC, Martin Williams
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Williams 2013-09-06 17:34:17 UTC
Created attachment 7702 [details]
Proposed patch

The ip3k interface has a useful 'Rescan Music Library' settings menu to initiate library scanning, and to set the scanning options. It is much more convenient than launching the web browser settings interface.

The 'Set Rescan Time' option has been broken for some time. It needn't be, the attached patch resolves the issue on my LMS.

The source of the problem appears to arise out of this commit:

Brought in line with new INPUT.Time functionality
https://github.com/Logitech/slimserver/commit/2b1bdd739d64c7a764f7c915e675d3772b034542

The problem is that the relevant preference setting - 'time' - used to be held in a mode parameter 'pref', and was referenced when setting the new rescan time. This commit removed the mode parameter, but did not address the subsequent use of that parameter.
Comment 1 Michael Herger 2013-09-08 20:01:17 UTC
Broken for... 5 years? And nobody complained before? :-)
Comment 2 Martin Williams 2013-09-08 20:41:54 UTC
I know. I should have moaned before !

I just don't change the rescan time very often. On the few occasions that I have wanted to, I would try it, issue a mild profanity, head off to the browser to do it, and then forget about it.

This time I allowed myself to be goaded into action.


It would be nice to be able to initiate/set scanning from Squeezeplay. But that's for another day...
Comment 3 Michael Herger 2013-09-09 13:05:24 UTC
change 28bc54d006e9684692aa3ec43b3c45321536ac24