Bug 18046 – Perl 5.18 breaks functionality in Info.pm

Bug 18046 - Perl 5.18 breaks functionality in Info.pm

Summary:

Perl 5.18 breaks functionality in Info.pm

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Playlists
Version:	7.7.2
Platform:	PC Other

Importance:	-- critical (vote)
Target Milestone:	7.7.x
Assigned To:	Michael Herger

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-08-24 13:55 UTC by Johannes
Modified:	2013-08-28 13:03 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Johannes 2013-08-24 13:55:44 UTC

LMS reports error in Info.pm+779

[Can't modify non-lvalue subroutine call at /opt/logitechmediaserver/Slim/Music/Info.pm line 779.

Whenever an album or track is added to the playing list.
The result is that no music is played. 

Radio streaming is not affected.

Removing line 779 from Info.pm seems to result in a working situation.

Comment 1 Michael Herger 2013-08-27 08:40:05 UTC

Would the following change fix it for real?

diff --git a/Slim/Music/Info.pm b/Slim/Music/Info.pm
index 4ca72f8..6095fd5 100644
--- a/Slim/Music/Info.pm
+++ b/Slim/Music/Info.pm
@@ -774,11 +774,16 @@
 
 	if (Slim::Music::TitleFormatter::cacheFormat($format)) {
 		$cache->{$format} = $text;
 	}
 
-	$client ? $client->musicInfoTextCache($cache) : $musicInfoTextCache = $cache;
+	if ($client) {
+		$client->musicInfoTextCache($cache);
+	}
+	else {
+		$musicInfoTextCache = $cache;
+	}
 
 	return $text;
 }
 
 #

Comment 2 Michael Herger 2013-08-28 13:03:05 UTC

I'm marking this fixed, as this particular case should be ok now. But I'm sure there will be more issues with perl 5.18. Please keep posting. You should open a generic "Perl 5.18 compatibility issues" bug. Thanks!