Bug 17901 - Some settings were changed. Do you want to save them?
: Some settings were changed. Do you want to save them?
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.7.2
: PC Windows 7
: -- normal with 2 votes (vote)
: 7.9.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-24 04:43 UTC by Lars Simonsen
Modified: 2015-05-28 04:37 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Simonsen 2012-02-24 04:43:38 UTC
Two related problems. The new one is definitely a bug, but the older one is annoying as well (and increasingly so).

1) Old, minor issue:

If you go to Settings, and open a drop down menu, close it again, and try to enter another tab, you get the question "Some settings were changed. Do you want to save them?" even if you didn't really change anything. 

The warning is too trigger-happy, it should only be activated if you actually changed something.

2) New, more severe issue in r33859 (Wed Feb 22 09:59:24 PST 2012):

"Some settings were changed. Do you want to save them?" YES - NO - CANCEL

* If you click YES, settings are saved and the tab changes. OK.
* If you click CANCEL, settings are not saved and the tab does not change. OK.
* If you click NO, settings are not saved (OK) and the tab does not change. (NOT OK). In other words, "NO" behaves exactly like "CANCEL".

Issue number 2 wouldn't have been so annoying if it wasn't for issue number 1, and vice versa. At least one of them should be fixed, preferably both.
Comment 1 Jim McAtee 2012-02-24 16:15:10 UTC
There is a small difference between 'No' and 'Cancel'. When you choose 'No', the warning is cleared and it lets you leave the tab the next time.

Yes, this is a new bug that doesn't exist in 7.6.2.
Comment 2 Jim McAtee 2014-05-27 16:04:37 UTC
Looks like the behavior of the 'No' button has been fixed in 7.7, 7.8 and 7.9. Thanks!
Comment 3 Michael Herger 2014-05-27 20:14:22 UTC
Oh, thanks for the confirmation. Forgot to update the bug report.
Comment 4 Jim McAtee 2015-05-22 20:16:29 UTC
I just noticed that this behavior is fixed when you try to change tabs within Settings, but not when you try to change sub-pages via the upper left drop-down menus. This can be seen in either Settings > Player or Settings > Advanced.

Reopen this bug or create a new one?
Comment 5 Michael Herger 2015-05-26 08:06:53 UTC
Reopen. Thanks!
Comment 6 Michael Herger 2015-05-28 04:37:35 UTC
commit 7ddb2a910ac3d50be4309e63e5c882f0d9879753

Thanks for the reminder.