Bug 17893 – Unnecessary push into current playlist when stopping playback - ip3k

Bug 17893 - Unnecessary push into current playlist when stopping playback - ip3k

Summary:

Unnecessary push into current playlist when stopping playback - ip3k

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	7.7.1
Platform:	All All

Importance:	P3 minor (vote)
Target Milestone:	7.7.2
Assigned To:	Michael Herger

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-02-20 08:06 UTC by Martin Williams
Modified:	2012-02-26 07:46 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Proposed patch (484 bytes, patch) 2012-02-20 08:06 UTC, Martin Williams	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Martin Williams 2012-02-20 08:06:22 UTC

Created attachment 7626 [details]
Proposed patch

On an ip3k device, stopping playback ('long press pause' on the remote) pushes
into playlist mode at the (now stopped) track.

Fine, unless you already happen to be already browsing the current playlist, in
which case pushing yet again into the playlist is, in my view, unnecessary and
confusing. Especially when there's only one item in the playlist (e.g.
continuous radio stream).

Proposed patch suppresses the 'push into current playlist on stop' when already
browsing the playlist.

Comment 1 SVN Bot 2012-02-23 21:54:50 UTC

 == Auto-comment from SVN commit #33862 to the slim repo by mherger ==
 == http://svn.slimdevices.com/slim?view=revision&revision=33862 ==

Fixed Bug: 17893
Description: when stopping playback don't push into playlist mode if already there

Comment 2 Michael Herger 2012-02-23 21:55:12 UTC

Thanks for you patch! Applied.

Comment 3 Martin Williams 2012-02-26 07:46:47 UTC

(In reply to comment #2)
Excellent ! Thank you. That's one little niggle off my list... :)