Bug 17875 - Slider in alarm volume screen not working
: Slider in alarm volume screen not working
Status: RESOLVED INVALID
Product: SB Radio
Classification: Unclassified
Component: Alarm
: 7.7.1
: PC Ubuntu Linux
: -- major (vote)
: 7.7.2
Assigned To: win.srisk@planet.nl
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-29 12:20 UTC by win.srisk@planet.nl
Modified: 2012-03-06 05:04 UTC (History)
1 user (show)

See Also:
Category: Bug


Attachments
screenshot of slider in Squeezeplay 7.6 (225.05 KB, image/png)
2012-01-29 12:20 UTC, win.srisk@planet.nl
Details
Screenshot with patched QVGAbaseSkin (225.05 KB, image/png)
2012-01-29 12:21 UTC, win.srisk@planet.nl
Details
patch for volume setting slider in Radio - QVGAbaseSkinApplet (514 bytes, patch)
2012-03-01 09:20 UTC, win.srisk@planet.nl
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description win.srisk@planet.nl 2012-01-29 12:20:22 UTC
Created attachment 7612 [details]
screenshot of slider in Squeezeplay 7.6

With Squeezebox Radio, firmware version 7.7.1 r9557 the slider in the screen to
set default Alarm Volume shows as in the attached screenshot; the right end is
complete out of the screen. This was taken from Squeezeplay 7.6, but in 7.7.1
on the Radio it is the same. It is still possible to adjust the Alarm volume,
but there is no visible feedback at which level you have it set.

I have traced this back to the QVGAbaseSkin applet, where the slider widget is
incorrectly set, around line 776 as s.volume_slider_group = s.slider_group. 
This should be s.settings_volume_group = s.settings_slider_group.
Still the slider looks a bit ugly, but it now shows the volume level, while the
user adjusts it with the large knob.

I will ad another screenshot with above corrections.
Comment 1 win.srisk@planet.nl 2012-01-29 12:21:44 UTC
Created attachment 7613 [details]
Screenshot with patched QVGAbaseSkin

Screenshot with patched QVGAbaseSkin
Comment 2 James Richardson 2012-02-29 13:47:21 UTC
Michael: Can you look at implementing this fix please
Comment 3 James Richardson 2012-02-29 14:07:05 UTC
Your fix looks good, can you include a patch so we can implement your fix
Comment 4 win.srisk@planet.nl 2012-03-01 09:20:45 UTC
Created attachment 7640 [details]
patch for volume setting slider in Radio - QVGAbaseSkinApplet
Comment 5 James Richardson 2012-03-05 09:30:32 UTC
Michael to implement
Comment 6 Michael Herger 2012-03-06 02:43:07 UTC
Are you sure this still is an issue? Or did you update a modified 7.6 to 7.7? In this case that particular file would not have been replaced by the update. Please run a factory reset and re-test. I'm not seeing this issue on my 7.7.1/9557 radio.
Comment 7 Michael Herger 2012-03-06 05:04:30 UTC
We confirmed this to be working as expected on two more devices. Feel free to re-open this bug if you still see this issue after a factory reset of your Radio.