Bugzilla – Bug 17858
Web UI shows red X instead of artwork for "local" remote streams
Last modified: 2013-05-16 14:01:24 UTC
http://forums.slimdevices.com/showthread.php?t=92860
Created attachment 7603 [details] Web UI Screen Shot
We most likely have fixed this in the mobile app - need to backport to SqueezeJS.
== Auto-comment from SVN commit #33873 to the slim repo by mherger == == http://svn.slimdevices.com/slim?view=revision&revision=33873 == Fixed Bug: 17858 Description: not all absolute URLs are publicly available. Don't use imageproxy for local addresses.
Andrew - could you please confirm this is now working as expected? Thanks!
Not only 172.16.x.x network is private, but 172.16.0.0/12 (172.16.x.x to 172.31.x.x, RFC1918) Your fix should be extended to be complete.
== Auto-comment from SVN commit #33875 to the slim repo by mherger == == http://svn.slimdevices.com/slim?view=revision&revision=33875 == Bug: 17858 Description: fix regex to fit private IP addresses. Thanks for the heads up, Emmanuel!
Created attachment 7660 [details] Fxies for Fix This fix breaks the facebook suff as facebooks image URL's are quite rightly over https.... So should we... , fix for images with https ie facebook screensavers and a complete private networks list... Patch with fixes...
(In reply to comment #7) > Created an attachment (id=7660) [details] > Fxies for Fix > > This fix breaks the facebook suff as facebooks image URL's are quite rightly > over https.... So should we... , fix for images with https ie facebook > screensavers and a complete private networks list... > > Patch with fixes... Sorry wrong bug but this does break for https urls also.... filed patch against right bug for squeezeplay...
Although this bug is marked as fixed, it seems that there are still edge cases where it does not work. For example, it works fine in the case where the cover art is served by JRiver Media Center with an URL as follows: http://192.168.1.33:52100/AArt/96.jpg BUT, it does NOT works in the case where the cover art is served by Windows Media Player with an URL as follows: http://192.168.1.33:10243/WMPNSSv4/813663920/0_e0NDRTc1NDlELTI1RjMtNEVFNS04NjFFLTlBQjRCMDRCNjBBNH0uMC40.jpg?albumArt=true Perhaps LMS still has problems to determine that WMP's long / parameterized URL is a local one??
Andrew - is this still an issue with 7.7.3 nightlies and/or 7.8? If so: what's the exact url being used in the web UI?
(In reply to comment #10) > Andrew - is this still an issue with 7.7.3 nightlies and/or 7.8? If so: > what's the exact url being used in the web UI? Frankly, I wouldn't know. Due to the product phase out, I scaled down my use of LMS to the absolute minimum needed to support my existing devices. And I am no longer interested in helping to extend the envelope or improve the product. Sorry.
Ok. Thanks.