Bug 1784 - radio streams play command could use rework from server side.
: radio streams play command could use rework from server side.
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Playlists
: 6.1.0
: All All
: P2 normal (vote)
: ---
Assigned To: KDF
http://localhost:9000
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-08 17:47 UTC by Patrick Cosson
Modified: 2009-09-08 09:25 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
example of how to make this work (3.88 KB, patch)
2005-07-13 02:07 UTC, KDF
Details | Diff
updated to include EN and HandHeld (11.26 KB, patch)
2005-07-13 21:05 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Cosson 2005-07-08 17:47:21 UTC
i am unable to select radio streams saved in several playlists.  the right pane remained empty eventhough 
i click on the play button.  below is a sample stream that did not work.
* http://rigel.th2.frontier.fr:8100

i installed the latest nightly.  i used a safari browser on a mac running 10.4.
Comment 1 KDF 2005-07-13 01:26:41 UTC
actually, I can't seem to play any item within a playlist.  playing the whole
playlist is fine.
Comment 2 KDF 2005-07-13 01:45:04 UTC
nevermind.  I bothced the code while trying to extract info.  songs work fine. 
streams within playlists seem to require the playlist add command in order to
work.  

This worked fine:
http://server:9000/index.html?player=<mac>&p0=playlist&p1=add&p2=http://205.188.234.38:8070/
Comment 3 KDF 2005-07-13 02:07:37 UTC
Created attachment 629 [details]
example of how to make this work

we can use the itemobj.isRemoteURL tt object to choose the url appropriate for
playing remote url's or local tracks.  This can be done rather quickly, in time
for 6.1.  Later, this could be kept or rework Pages.pm to serve up more of the
url so that the skins don't have to code so much of it.

This example is for fishbone and default skins.
Comment 4 KDF 2005-07-13 21:05:04 UTC
Created attachment 631 [details]
updated to include EN and HandHeld

Have tested with all 4, and individual urls within playlist will play/add
Comment 5 Dan Sully 2005-07-19 14:06:56 UTC
kdf - can you check this in, if you haven't already?

Thanks.
Comment 6 KDF 2005-07-19 14:26:50 UTC
will do.
Comment 7 KDF 2005-07-19 19:07:52 UTC
committed at change 3752.

punting post 6.1 for consideration of server rework to make this cleaner
Comment 8 Blackketter Dean 2005-08-21 17:38:29 UTC
kdf:  what more needs to be done here?
Comment 9 KDF 2005-08-21 18:08:20 UTC
I'm not sure really.  I thought originally that the server could feed the needed command (addtracks/add 
or playtracks/play) but that seem to just be more of the problem by being too specific.  If the current 
method used in the skins is ok, we can close this off.  They do work.
Comment 10 KDF 2005-08-26 15:16:58 UTC
Dean,

If you are fine with the skins handling this (as in Default, EN, HandHeld and
Fishbone), I can simply make sure the rest of the included skins are done this way.
Comment 11 KDF 2005-08-30 13:06:48 UTC
Moser and Touch skin done at change 4124.
that seems to be all the skins that need it now.