Bug 17763 - App is stuck in landscape mode on some smartphones
: App is stuck in landscape mode on some smartphones
Status: RESOLVED FIXED
Product: Controller App
Classification: Unclassified
Component: User Interface
: 1.1
: Macintosh Android (please specify version)
: P1 normal
: 1.1
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-14 00:02 UTC by Michael Herger
Modified: 2011-12-01 13:51 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
improved tablet mode detection, add option to disable landscape mode (deleted)
2011-11-16 08:24 UTC, Michael Herger
Details
new build to sync up with the iOS build (deleted)
2011-11-21 22:43 UTC, Michael Herger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Herger 2011-11-14 00:02:24 UTC
Some high-end phones with large screens are considered tablets and get stuck in landscape mode. We need to improve the tablet detection logic and add an option to change the default behaviour.
Comment 1 SVN Bot 2011-11-14 01:11:51 UTC
 == Auto-comment from SVN commit #8521 to the player repo by mherger ==
 == http://svn.slimdevices.com/player?view=revision&revision=8521 ==

Bug: 17763
Description: no need to double-check tablet mode
Comment 2 Michael Herger 2011-11-14 01:12:54 UTC
Before putting the app into landscape mode we need to apply the same checks as we do before we enable split view mode. Only in this case we should the app in "tablet mode".
Comment 3 SVN Bot 2011-11-14 01:26:37 UTC
 == Auto-comment from SVN commit #8522 to the player repo by mherger ==
 == http://svn.slimdevices.com/player?view=revision&revision=8522 ==

Bug: 17763
Description: no need to re-evaluate width/height if it's already known
Comment 4 Michael Herger 2011-11-16 08:24:24 UTC
Created attachment 7567 [details]
improved tablet mode detection, add option to disable landscape mode
Comment 5 jonathan 2011-11-19 16:30:08 UTC
Had same problem on LG Optimus Black. Installed the attachment (had to uninstall existing app) and it now switches reliably between landscape and portrait. However, landscape seems to have split screen which does not work well on a 4 inch screen. Only the right-hand side of the playlist can be seen, and it covers up the information from the usual Now Playing screen. So you can't see either part sufficiently.
Comment 6 jonathan 2011-11-19 16:34:58 UTC
(In reply to comment #5)
> However, landscape seems to have split screen which does not work
> well on a 4 inch screen. Only the right-hand side of the playlist can be seen,
> and it covers up the information from the usual Now Playing screen. So you
> can't see either part sufficiently.
Found the 'Use high resolution' setting. Switching to landscape, this momentarily goes to a split screen (which despite the high resolution, still has the problem that the right side is partially covered by the playlist on the left). However it then switches to the My Music menu. Switching back to portrait correctly shows the  Now Playing screen.
Comment 7 Michael Herger 2011-11-21 22:43:09 UTC
Created attachment 7571 [details]
new build to sync up with the iOS build

> Had same problem on LG Optimus Black. Installed the attachment (had to
> uninstall existing app) and it now switches reliably between landscape and
> portrait. However, landscape seems to have split screen which does not work
> well on a 4 inch screen. Only the right-hand side of the playlist can be seen,
> and it covers up the information from the usual Now Playing screen. So you
> can't see either part sufficiently.

Could you please tell me what you get from the app's Settings/Advanced/About screen (with and without the "hires" option enabled)?
Comment 8 Michael Herger 2011-11-22 04:52:53 UTC
The content of attachment 7567 [details] has been deleted by
    Michael Herger <michael@slimdevices.com>
without providing any reason.

The token used to delete this attachment was generated at 2011-11-22 04:52:50 PST.
Comment 9 Michael Herger 2011-11-22 04:55:42 UTC
The content of attachment 7571 [details] has been deleted by
    Michael Herger <michael@slimdevices.com>
without providing any reason.

The token used to delete this attachment was generated at 2011-11-22 04:55:39 PST.
Comment 10 Michael Herger 2011-11-23 01:55:32 UTC
This should be fixed in the upcoming 1.1.3 release.
Comment 11 jonathan 2011-11-23 16:43:01 UTC
(In reply to comment #7)
> Could you please tell me what you get from the app's Settings/Advanced/About
> screen (with and without the "hires" option enabled)?

Version: 1.1.3/r8523
Network connection type: wireless
Connection type: Comet
Device information:
Name: lge_bprj
Platform: Android
Version: 2.2.2
Display: 480x762/1.5 (HI-RES)
Display: 320x508/1.5 (LO-RES)
Comment 12 Michael Herger 2011-11-23 22:11:46 UTC
Thanks! This seems to explain the issue you're seeing:

> Display: 480x762/1.5 (HI-RES)
> Display: 320x508/1.5 (LO-RES)

This can't be correct: the 1.5 defines a factor by which your device's physical resolution is scaled down. It cannot be 1.5 for both modes. The first case would mean it had a 720x1200px display.

I've seen this happen with other devices before. Would using the "Force Up-Scaling" option give you the larger fonts and get rid of the broken split-view?
Comment 13 jonathan 2011-11-24 05:48:03 UTC
(In reply to comment #12)
> This can't be correct: the 1.5 defines a factor by which your device's physical
> resolution is scaled down. It cannot be 1.5 for both modes. The first case
> would mean it had a 720x1200px display.

Double-checked and that's definitely what it shows.

> I've seen this happen with other devices before. Would using the "Force
> Up-Scaling" option give you the larger fonts and get rid of the broken
> split-view?

No, 'Force Up-Scaling' seems to have the same effect as 'Use High Resolution' although that option is not ticked. So, to get large font neither option can be ticked. If either option is ticked then I get high resolution (which on the whole I'd prefer) but with the undesirable side effects when used landscape.
Comment 14 Michael Herger 2011-11-24 09:29:19 UTC
But at least you can force it into portrait mode, can't you?
Comment 15 jonathan 2011-11-24 09:39:22 UTC
(In reply to comment #14)
> But at least you can force it into portrait mode, can't you?
Yes, indeed. You can switch to and from portrait and landscape freely, but obviuosly confusing to be faced with the main menu when in lanscape mode (having briefly been shown the split screen).
Comment 16 jonathan 2011-12-01 13:51:05 UTC
And have just found that the split screen works perfectly provided you're showing the playlist in portrait mode then switch to landscape. Playlist shifts to the left, with Now Playing screen on the right. Very nice.