Bugzilla – Bug 17639
Rescan buttons scans the wrong folder
Last modified: 2011-12-13 22:22:50 UTC
Created attachment 7500 [details] scanner log Rescan buttons scans the wrong folder. It actually looks like it's scanning every folder *but* the one you choose ?
Created attachment 7501 [details] server log
Created attachment 7502 [details] Basic settings
Created attachment 7503 [details] Information
I proved it by putting new music in my music folder and ordered a scan of my picture folder.
did you at the same time change some of your settings? Or was another scan still going on in the background?
No other scan afaik ? server has not been running for very long . And the whole machine was recently rebooted .
The actual scan went very well btw new music added. Btw I did not have any new pictures. I saw this behavior a while back, but I had not reprodueced it properly , and you latest fix made it possible to get past the deleting files stage, so I could let the scan complete.
Created attachment 7504 [details] scanner.log Scan without any new files at all, log would probably contain previus scan
Created attachment 7505 [details] Server.log A server log . I notice that my total album count was 3 albums less after this scan ? without adding or removing any files
yet another scan for pictures that finds music and do a lot of stuff . The Björk album is new the Ane Brun Album was scanned via BMF this did not stop the scanner from rescanning it Will attach scan log I may have to zip it
Created attachment 7507 [details] scanner log
(In reply to comment #11) > Created an attachment (id=7507) [details] > scanner log This last log is from a full wipe/rescan, or it shouldn't run the external scanner. In this case it's expected to scan music as well as other media types. Did you click the Rescan button right of the path entry?
(In reply to comment #12) > (In reply to comment #11) > > Created an attachment (id=7507) [details] [details] > > scanner log > > This last log is from a full wipe/rescan, or it shouldn't run the external > scanner. In this case it's expected to scan music as well as other media types. > > Did you click the Rescan button right of the path entry? yes the rescan button beside the path entry, full rescan not possible it is finished within minutes it takes hours to rescan everything thing. When I press the rescan button for pictures all other scan buttons also get greyd out ? Is this normal.
I tried after a complete rescan to add a new album, same result. To me it looks like both buttons actually does almost the same thing for me . Do you have any objections to my folder structure . /media/music /media/music/Mina bilder (pictures) /media/music/Playlists Yes playlist and pictures are under music I assume that LMS is smart enough to exclude those ?
> Do you have any objections to my folder structure . > /media/music > /media/music/Mina bilder (pictures) > /media/music/Playlists > > Yes playlist and pictures are under music I assume that LMS is smart enough to > exclude those ? Andy - how smart are we about this kind of setting? It seems the audioscan would find images, but "remove" them on every rescan.
Hmm yeah, nested paths like that may not work right...
(In reply to comment #16) > Hmm yeah, nested paths like that may not work right... had the same playlist directory since 6.x without problems. It is historical reasons behind this :-/ Can this be related: https://bugs-archive.lyrion.org/show_bug.cgi?id=16081 Should this be supported ? If you think this should be supported I can keep my systems as it is and continue to test this. It might be more common than you think imagine a generic network shared low-budget NAS with a very flat folder structure... Otherwise I could remount my two discs (music is more than one disc, there is a music2 with even more folders nested inside that :-/ ) . And modify my samba setup etc.
Tried your theory of my nested mounts ,now my music folders looks like. /media/sda1/music1 (music ) /media/sdb1/music2 (more music ) /media/sda1/Mina bilder (the picture folder) /media/sda1/Playlists (my playlists ) it still scans all/wrong folders whatever i do . So this bug is still valid Even if I select a playlist scan it does a look for new and changed in all folders ? I will upload more scan logs , note that my playlist are broken, I'm adjusting them now (an effect of the relocation)
Created attachment 7513 [details] server.log
Created attachment 7514 [details] scanner.log
> /media/sda1/Playlists (my playlists ) Did you add this folder in the Playlist folder setting, or as one of the media folders?
Mikael - the scan is failing due to a database lock caused by TrackStat. Please disable all 3rd party plugins and try again. In order to know what's going on we really need as little "outside" influence as possible. Erland should probably add some code to not try to write to the DB while a scan is going on...
(In reply to comment #21) > > /media/sda1/Playlists (my playlists ) > > Did you add this folder in the Playlist folder setting, or as one of the media > folders? This is the playlist folder setting it's not a media folder
Trying out tis without erlands plugins . Scan for pictures or videos does not find music all is ok there . However scanning for music in the folder where there is no new music makes the server crash ? Rebooting and trying again...
And it resumes and endless scan after restart that I have to abort...
Created attachment 7524 [details] crash_server.log it actually crashes when I sscan the dir where the new music is i attache log . Is this another already known bug ? it actually looks like it's trying the start the scan again after it ended ??
when I removed all erlands plugins this particular bug is resolved . I create a new one for the segfaults I now get when I actually can do these scans...
Thanks for all the hard testing anyway :-)
I don't have the permission to reopen this bug but hopefully someone that sees this comment have the permission to do it. The issue is not specific to third party plugins, activating the standard MusicIP plugin gives exactly the same behavior in my system. I suspect the same thing might also happen with the iTunes plugin as it also registers an importer. The issue is probably related to if there is any plugin that calls: Slim::Music::Import->addImporter Slim::Music::Import->useImporter This is currently done in at least: - MusicIP (bundled with LMS) - iTunes (bundled with LMS) - CustomBrowse (third party) - CustomSkip (third party) - DynamicPlaylist (third party) - SQLPlayList (third party) - TrackStat (third party) - CustomScan (third party, not sure this affects things as the add/use Importer is only called when launched from external scanner) There is a suspected change in r33453 but I haven't investigated if that's the cause of these problems. I'll try to see if I can remove the add/useImporter calls in my own plugins as most of them only use it to register mixers and I'm not sure I need to use importer in 7.6+ for that. However, Logitech still needs to solve the issues in MusicIP and also in iTunes (if it have the same issues, haven't tried this as I'm on Linux).
I could change it back to unconfirmed . Some one else have to get it back to confirmed.
We need to support singledir mode in the external scanner. Right now whenever the external scanner is being launched (which happens if you have additional importers defined, such as MIP, iTunes, or some of Erland's) a scan of all folders would be triggered.
== Auto-comment from SVN commit #33657 to the slim repo by mherger == == http://svn.slimdevices.com/slim?view=revision&revision=33657 == Fixed Bug: 17639 Description: pass singledir value to external scanner
Verification passed on 7.7.1 r33735, able to scan the media from directories/sub directories including iTunes music on window, mac and ubuntu.