Bug 17634 - Random art represents an album as cover art, if there is track art avaible
: Random art represents an album as cover art, if there is track art avaible
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Artwork
: 7.7.0
: PC All
: P2 normal with 4 votes (vote)
: 7.7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-07 08:46 UTC by Mikael Nyberg
Modified: 2013-05-17 02:26 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Nyberg 2011-10-07 08:46:49 UTC
Hard for me me to put good english on the  the description .

A tread where we discus it

http://forums.slimdevices.com/showthread.php?t=90749&highlight=Image

I hava 2 scenarios .

David Byrne And Brian Eno:

"Everything That Happens Will Happen Today"

There is a folder.jpg with the album cover.

Every song except one has the exact same image embedded except track nr 7 which intentionally have another image.

The image from track 7 is chosen as "album" art by SBS/LMS

Kim Boekbinder:

"The Impossible Girl"

There is a folder.jpg with the album cover.

Every song has a different artwork track 1 has the same art as the album cover

The "album" art is the artwork from track 19


There is some logic but what is it ?

Another user have problems with a compilation of singles (not an uncommon format with some music genres) where each track have it's own art.

Suggestions from me:

If an album have different art at track level elect the folder.jpg/cover.jpg to represent the whole album in views where "albums" are concerned and let the tracks have their own art always .

It is not like that now if I do a song search and get a song from the "Kim Boekbinder" album it will be represented by art from track 19 even if it is another track untill I play it ,then the art will change to the track art .

If you want I can give you the Kim Boekbinder album (or shop at Bandcamp)
Comment 1 Mikael Nyberg 2011-10-07 08:51:33 UTC
I do understand that they are other iterations, such as if there is no "folder.jpg" .

Here the old behavior use art from track 1 can be used
Comment 2 vagskal 2011-10-07 09:05:25 UTC
In 7.5 SBS selected the album art for the very first track in the album (according to track no., at least when the album art was embedded in that file) to be the album art for the entire album in album list views. This was a good and predictable logic. It made it possible to have a dummy file with track no. 00 and the embedded album art the user wanted to represent the entire album even when the other (genuine) tracks had different album/track art.

A reintroduction of that logic seems to be able to take care of the two examples listed by the reporter.
Comment 3 Mikael Nyberg 2011-10-07 09:36:24 UTC
Good, hopefully we get more suggestions ( and votes ).

Current behavior is unpredictable that is a problem.
Comment 4 Mikael Nyberg 2011-10-07 22:44:10 UTC
I separated the search issue to it's own bug.

https://bugs-archive.lyrion.org/show_bug.cgi?id=17635
Comment 5 Mikael Nyberg 2011-10-08 02:44:53 UTC
(In reply to comment #2)
> In 7.5 SBS selected the album art for the very first track in the album
> (according to track no., at least when the album art was embedded in that file)
> to be the album art for the entire album in album list views. This was a good
> and predictable logic. It made it possible to have a dummy file with track no.
> 00 and the embedded album art the user wanted to represent the entire album
> even when the other (genuine) tracks had different album/track art.
> 
> A reintroduction of that logic seems to be able to take care of the two
> examples listed by the reporter.

I was thinking some more, this would actually be a working compromise if the devs don't want to spend to much time.
It does not break the logic where embedded art always overides folder art.

I'm beginning to supect that the actual logic atm is " first scanned file sets album cover " then the disc file system may be a factor, it may not be track 1 or the alphabetically first file that is first scanned ?
Comment 6 Mikael Nyberg 2011-10-09 04:11:29 UTC
Adding more examplefiles to the ftp server .

Using track1 picture as album cover, seems possible the 5 example albums I uploaded have what to be considered the cover art as the art for the first track1
The tracks should of course be represented by their own art.

Even if art varies in all the other tracks, in this world without standards , this seems consistent .

This logic still have some flaws, but it improves greatly upon what we have now and it is predictable .

Theoretically there can be:

An album where the cover art is in another random track and not represented by track1.

A album where the cover art is only the folder.jpg/cover.jpg and all the track art differs from that .

Never seen one of those yet in reality
Comment 7 Mikael Nyberg 2011-10-10 14:55:29 UTC
Another fascinating development, the kim boekbinder album it changed cover art ?
Now it uses track 9 as album cover ? i have not touched the files, so what can it be ?
This happened to one of my other albums to.
Theory, these albums where added with " browse music folder" when a real scan comes it does something with these albums ?
Comment 8 Mikael Nyberg 2011-11-02 22:30:06 UTC
Bump, I've been shoping a lot on Bandcamp lately and it is a very common practice to deliver per track artwork onmthese albums. Should I upload some more samples to the bug ?
Comment 9 Digital Mitch 2011-11-03 07:36:18 UTC
*** This bug has been confirmed by popular vote. ***
Comment 10 Mikael Nyberg 2012-03-14 19:15:41 UTC
Adjusted bug name, it where never rigth :)
Comment 11 Michael Herger 2013-05-16 04:38:06 UTC
What I understand is that the album artwork would be the artwork of the last track scanned within an album. As no sort order is defined during the pre-caching, the result can be "random".

I can tell it to order by tracknum desc, increasing the probability of the first track being chosen. While this is relatively cheap, it's not the definite solution.
Comment 12 Michael Herger 2013-05-16 10:33:59 UTC
Commit: fb4ac0b552fa6ec66a3efc32c8c241e2bb6d22d9 [fb4ac0b]

For albums where we have different track artwork, use the first track's
cover as the album artwork.
Comment 13 Mikael Nyberg 2013-05-17 02:26:55 UTC
Thanx I’ll upgrade and try asap .

I will also do a full clear and rescan before expecting any change