Created attachment 7475 [details]
Repeat song icon showing in iconbar

This bug is applicable to Squeezeplay v7.6.
SB Radio FW is v7.6.1-r9482.

The 'repeat mode' icon does not currently appear in the icon bar (bottom of
screen on Radio). It is supposed to be shown next to the 'playmode' icon.
Attached is a screenshot of how it *should* look in 'repeat single song' mode.


The iconbar display appears to have been inadvertently lost in the process of
tidying up party/playlist modes. Refer Squeezeplay 7.6 revisions r8924 & r8925.

The basic issue is that the 'updateIconbar' function of
'squeezeplay/share/jive/slim/Player.lua' currently sets the repeat mode to
'off', regardless of what the repeat mode actually is.

The patch below has been tested on SB Radio v7.6.1-r9482, and on Squeezeplay
7.6.2 r9542 using the relevant skins QVGA landscape & QVGA portrait. WQVGA
skins do not show the icon bar, and are not affected.

jive/Iconbar.lua:
Remove 'preferPlaylistModeIcon' test - this related to the now defunct 'party
mode' and is no longer relevant, or defined.

jive/slim/Player.lua:
Set repeat mode to the current setting instead of always 'OFF'.

[Diff file referenced to 7.6/trunk/squeezeplay]


 Index: src/squeezeplay/share/jive/Iconbar.lua
===================================================================
--- src/squeezeplay/share/jive/Iconbar.lua    (revision 9542)
+++ src/squeezeplay/share/jive/Iconbar.lua    (working copy)
@@ -75,10 +75,7 @@
 --]]
 function setRepeat(self, val)
     log:debug("Iconbar:setRepeat(", val, ")")
-    self.repeatMode = string.upper((val or "OFF"))
-    if not self.preferPlaylistModeIcon then
-        self.iconRepeat:setStyle("button_repeat_" .. self.repeatMode)
-    end
+    self.iconRepeat:setStyle("button_repeat_" .. string.upper((val or "OFF")))
 end


Index: src/squeezeplay/share/jive/slim/Player.lua
===================================================================
--- src/squeezeplay/share/jive/slim/Player.lua    (revision 9542)
+++ src/squeezeplay/share/jive/slim/Player.lua    (working copy)
@@ -1153,7 +1153,8 @@

         -- alarm icon in iconbar is set directly via AlarmSnoozeApplet

-        iconbar:setRepeat(0)
+        -- set the repeat (nil, 0=off, 1=single track, 2=all playlist tracks)
+        iconbar:setRepeat(self.state['playlist repeat'])

         --[[ useful for layout skinning debug, set all modes to show icons
             iconbar:setPlaymode('play')