Bug 17586 - Type 'mov' has been removed but is still in the code for MP4 podcasts.
: Type 'mov' has been removed but is still in the code for MP4 podcasts.
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Streaming To SlimServer
: 7.7.0
: PC Other
: P1 normal (vote)
: 7.7.0
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-24 01:31 UTC by Bryan Alton
Modified: 2011-10-12 07:13 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Alton 2011-09-24 01:31:22 UTC
In 7.7 the type "mov" has been removed from types.conf so the code in Scanner/Remote.pm
Code:
	# Bug 3396, some m4a audio is incorrectly served as audio/mpeg.
	# In this case, prefer the file extension to the content-type
	if ( $url =~ /(m4a|aac)$/i && $type eq 'mp3' ) {
		$type = 'mov';
	}
Should be changed to something like 
Code:
	# Bug 3396, some m4a audio is incorrectly served as audio/mpeg.
	# In this case, prefer the file extension to the content-type
	if ( $url =~ /(aac)$/i && ($type eq 'mp3' || $type eq 'txt' ) ) {
		$type = 'aac';
	}

	if ( $url =~ /(m4a|mp4)$/i && ($type eq 'mp3' || $type eq 'txt' ) ) {
		$type = 'mp4';
	}
This handles m4a/mp4 podcasts slightly better which not only sometimes has audio/mpeg but also the "txt" MIME designation.
Comment 1 SVN Bot 2011-09-26 06:19:44 UTC
 == Auto-comment from SVN commit #33519 to the slim repo by agrundman ==
 == http://svn.slimdevices.com/slim?view=revision&revision=33519 ==

Fixed bug 17586, mov type now needs to be aac or mp4