Bugzilla – Bug 17555
TinySBS on Touch crashes when there are GIF files in a music folder
Last modified: 2011-09-13 11:56:06 UTC
Plugged in a backup of my music library. For legacy reasons some of the albums still have accompanying GIF files, like thumb.gif or cover.gif. SBS crashes as soon as it tries to resize one of the cover.gif files. In one case it even crashed when resizing a cover.jpg where there was a thumb.gif. I didn't encounter any crash yet in a folder with both cover.jpg and thumb.jpg, or one of them alone. It's always crashing when a GIF is around. Sep 8 18:04:07 slimserver.pl: [11-09-08 18:04:07.9939] Slim::Utils::Misc::msg (1236) Warning: [18:04:07.9863] Loading image from /media/sda1/Musig/John Paul Jones - Zooma/cover.gif Sep 8 18:04:10 kernel: BUG: sleeping function called from invalid context slimserver.pl(25656) at kernel/rtmutex.c:743 Sep 8 18:04:10 kernel: in_atomic():0 [00000000], irqs_disabled():128 Sep 8 18:04:10 kernel: [<c02f1760>] (dump_stack+0x0/0x14) from [<c00473b0>] (__might_sleep+0x104/0x128) Sep 8 18:04:10 kernel: [<c00472ac>] (__might_sleep+0x0/0x128) from [<c02f4360>] (__rt_spin_lock+0x38/0x68) Sep 8 18:04:10 kernel: r4:c57f8fc4 Sep 8 18:04:10 kernel: [<c02f4328>] (__rt_spin_lock+0x0/0x68) from [<c02f43a0>] (rt_spin_lock+0x10/0x14) Sep 8 18:04:10 kernel: r4:c73cc520 r3:c73cc520 Sep 8 18:04:10 kernel: [<c02f4390>] (rt_spin_lock+0x0/0x14) from [<c005adf0>] (force_sig_info+0x2c/0xdc) Sep 8 18:04:10 kernel: [<c005adc4>] (force_sig_info+0x0/0xdc) from [<c0032884>] (arm_notify_die+0x48/0x54) Sep 8 18:04:10 kernel: r8:014bcc38 r7:60000093 r6:c03d819c r5:4075822c r4:c425ffb0 Sep 8 18:04:10 kernel: r3:c73cc520 Sep 8 18:04:10 kernel: [<c003283c>] (arm_notify_die+0x0/0x54) from [<c002e1fc>] (do_undefinstr+0x19c/0x1b8) Sep 8 18:04:10 kernel: [<c002e060>] (do_undefinstr+0x0/0x1b8) from [<c002ea80>] (ret_from_exception+0x0/0x10) Sep 8 18:04:10 kernel: Exception stack(0xc425ffb0 to 0xc425fff8) Sep 8 18:04:10 kernel: ffa0: ffffffff 000001d7 02ab7c20 401b4f0c Sep 8 18:04:10 kernel: ffc0: 000012d0 40744178 4074a698 40284000 00000020 be874b4c 02adcaf8 401b4f0c Sep 8 18:04:10 kernel: ffe0: be874b34 407594f8 40758228 4075822c 40000010 ffffffff Sep 8 18:04:10 kernel: r8:00000020 r7:40284000 r6:4074a698 r5:40744178 r4:4075822c Sep 8 18:04:12 squeezeplay: WARN applet.SqueezeboxFab4 - SqueezeboxFab4Applet.lua:830 SC guard timer - SC got killed!!!
firmware 7.6.2, r9500
Created attachment 7455 [details] GIF crashing the server
Created attachment 7456 [details] another crashing GIF This file was together with a cover.jpg file in the same folder. TinySBS would crash on cover.jpg, as long as that GIF file was there. I renamed it, and cover.jpg converted just fine...
Yeah... never got around to hooking up giflib for Fab4 I think.
The issue would be absorbed if the gdresided was being used. Unfortunately this doesn't happen, as the call to ImageResizer->resize() is done without a callback.
== Auto-comment from SVN commit #33357 to the slim repo by mherger == == http://svn.slimdevices.com/slim?view=revision&revision=33357 == Bug: 17555 Description: ignore GIF files on TinySBS/Touch as long as we haven't fixed the giflib and/or gdresized issue
giflib is fixed (as long as the build runs on centos01). To work around a Perl Makefile issue the libraries need to also be installed in /usr/lib so it doesn't remove them from the linker command line. I will also revert the change to skip gif files.
== Auto-comment from SVN commit #33431 to the slim repo by agrundman == == http://svn.slimdevices.com/slim?view=revision&revision=33431 == Bug 17555, revert gif skipping code for Touch