Bug 17515 - First line of podcast listing is blank in SB Classic - should show "About this feed"
: First line of podcast listing is blank in SB Classic - should show "About thi...
Status: UNCONFIRMED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 7.6.0
: All All
: -- normal (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-28 15:20 UTC by Martin Williams
Modified: 2011-08-30 01:00 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Williams 2011-08-28 15:20:28 UTC
1. Blank first line

Slim::Buttons::gotRSS prepends a podcast listing with an 'About this feed' item which 'onRight' shows the feed description.

The item is given the 'name' attribute '{XML_FEED_DESCRIPTION}'. But this is overridden by the 'name' mode-param CODE-ref that applies to the feed as a whole (which returns each item's 'title' attribute). Result = nothing.

Appears to be a side-effect of recent changes made to Input.Choice handling. (One browser ?)

Fix could be to give this item its own name CODE-ref, or a 'title' attribute.


2. Errors with 'onPlay' & 'onAdd' handling

These two buttons appear to have been given the task of playing/adding to playlist the entire feed.

However:

a) They don't. An error is generated through trying to play/add the podcast URL.

b) IMO it is not appropriate for an 'About this feed' item to be playing/adding them anyway. Some podcasts have a large number of episodes.

Fix could be to give these two buttons a 'bump right' action.
Comment 1 Martin Williams 2011-08-28 15:32:18 UTC
correction:

Slim::Buttons::XMLBrowser::gotRSS prepends a podcast listing...
Comment 2 SVN Bot 2011-08-29 02:45:21 UTC
 == Auto-comment from SVN commit #33237 to the slim repo by mherger ==
 == http://svn.slimdevices.com/slim?view=revision&revision=33237 ==

Bug: 17515
Description: fix missing "about podcast" line on ip3k
Comment 3 Martin Williams 2011-08-30 01:00:45 UTC
(In reply to comment #2)
> == Auto-comment from SVN commit #33237 to the slim repo by mherger ==
>  == http://svn.slimdevices.com/slim?view=revision&revision=33237 ==
> 
> Bug: 17515
> Description: fix missing "about podcast" line on ip3k

Thanks for that.

Will the issue "2. Errors with 'onPlay' & 'onAdd' handling" be addressed as well, or is it better dealt with on a separate bug report ?