Bug 175 - using sort order makes pagination unusable
: using sort order makes pagination unusable
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: unspecified
: All All
: P2 normal (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-01-29 16:24 UTC by michael
Modified: 2008-12-15 11:57 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Patch to fix the sort order pagebar problem (1.22 KB, patch)
2004-02-02 23:01 UTC, Ted Rathkopf
Details | Diff
Corrected patch to fix sort order pagebar problem (1.22 KB, patch)
2004-02-02 23:07 UTC, Ted Rathkopf
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description michael 2004-01-29 16:24:37 UTC
With the recently submitted patch, I finally have slim server paying attention
to my TSOP tags. This makes the "Browse Artists" page listing much more
intuitive, but unfortunately it makes the pagination of that frame completely
unusable.

Before I had TSOP working properly, the line at the top and bottom of that
frame/page would read:
"A B C D E F G H I J K L M N O P Q R S T U V W X Y Z"
and I could jump exactly to the page with the artist I was looking for.

Now the same area reads:
"A B A H A M A D T A L A F A D A B J B J B L B P B J B N B D L B M B W B K B C J
T C N C S M C N C P C L C J C H C E C J C D G D M D M D A D S D E D E D E F B F
D F P D G L B G H N H M H M H B H B H I J I B I J E J L J G T J K A N K C K E K
D K E L C L J A L D M A M H M L S M T M A G M A M V A W M P M N J N G N M S O P
O P Q R L R L R S F S F S L S J S B S C A S R S T B U P V S V C V W A W B W X Y F Z"
which isn't terribly useful for finding a particular artist.

Perhaps the pagination functions could be made to use the sort ordering as well
and thus restore it's usability?

I can only assume that the same issue would affect TSOA and TSOT tags, though I
haven't tried using those myself.
Comment 1 Ted Rathkopf 2004-02-02 23:01:23 UTC
Created attachment 7 [details]
Patch to fix the sort order pagebar problem

This fixes the sort order pagebar problem by creating a new function in
Slim/Music/Info.pm to return a SortName for an item, if it exists, and then
calls that function in alphapagebar in Slim/Web/Pages.pm so that the pagebar is
created using the sortnames where applicable.
Comment 2 Ted Rathkopf 2004-02-02 23:04:38 UTC
Comment on attachment 7 [details]
Patch to fix the sort order pagebar problem

There's a typo in the patch.  a ) is missing to close the call to getSortName.
Comment 3 Ted Rathkopf 2004-02-02 23:07:17 UTC
Created attachment 8 [details]
Corrected patch to fix sort order pagebar problem

The previous patch was missing a ).
Comment 4 Blackketter Dean 2004-02-03 08:44:48 UTC
You Rock Ted!  Thanks.  Applied.
Comment 5 michael 2004-02-03 16:06:10 UTC
This works great. Thanks!
Comment 6 James Richardson 2008-12-15 11:57:01 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.