Bugzilla – Bug 17489
Artists containing ')' characters break a few things
Last modified: 2011-08-26 06:09:00 UTC
Created attachment 7416 [details] Sunn O))) - Flight of the Behemoth (single-file FLAC, stripped of audio data) The canonical spelling of the name of this band: http://en.wikipedia.org/wiki/Sunn_O))) ..is: Sunn O))) With the advent of 7.6, this prevents me from viewing the album page for any of their albums, though I can still play them by using the 'add' and 'play' buttons in the album browser. Here are some example errors from the server log: [11-08-19 23:17:56.5954] Slim::Web::Template::SkinManager::_fillTemplate (318) Error: undef error - Unmatched ) in regex; marked by <-- HERE in m/Sunn O) <-- HERE ))/ at /usr/local/squeezeboxserver/CPAN/Template/VMethods.pm line 146. [11-08-19 23:18:04.2949] Slim::Web::Template::SkinManager::_fillTemplate (318) Error: undef error - Unmatched ) in regex; marked by <-- HERE in m/Sunn O) <-- HERE ))/ at /usr/local/squeezeboxserver/CPAN/Template/VMethods.pm line 146. [11-08-19 23:18:17.7016] Slim::Utils::Misc::msg (1236) Warning: [23:18:17.7014] Image::Scale cannot rotate, unknown orientation value: 0 (/mnt/audio/Albums/Sunn O)))/Flight of the Behemoth/Flight of the Behemoth.flac) [11-08-19 23:32:10.2064] Slim::Web::Template::SkinManager::_fillTemplate (318) Error: undef error - Unmatched ) in regex; marked by <-- HERE in m/Sunn O) <-- HERE ))/ at /usr/local/squeezeboxserver/CPAN/Template/VMethods.pm line 146. Server status: Version: 7.6.1 - r33110 @ Thu Aug 18 04:20:33 MDT 2011 Hostname: tonearm.local Server IP Address: 10.1.1.33 Server HTTP Port Number: 9000 Operating system: freebsd - EN - utf8 Platform Architecture: i386-freebsd Perl Version: 5.8.9 - i386-freebsd-64int Database Version: DBD::SQLite 1.34_01 (sqlite 3.7.7.1) Total Players Recognized: 3 Attached is an example album that should fail in the indicated way (stripped of audio data, but in the same kind of directory hierarchy I am using while encountering this bug).
Just tried this out on r33148 with a complete cache purge / rescan, and it behaves the same.
It's not just parentheses. I have the same problem as Wilson with Sunn O))), and a similar problem with the Sunn O))) mockery called \\\Maytag, although in this case I'm still able to view the album page. [11-08-23 20:03:10.4260] Slim::Utils::Misc::msg (1236) Warning: [20:03:10.4249] Unrecognized escape \M passed through in regex; marked by <-- HERE in m/\\\M <-- HERE aytag/ at /usr/local/squeezeboxserver-7.6.1-33148-FreeBSD/CPAN/Template/VMethods.pm line 146. SBS r33148. Also FreeBSD, but I hope that isn't relevant.
Created attachment 7421 [details] patch
Fixes this specific case. There may be more. :)
== Auto-comment from SVN commit #33212 to the slim repo by mherger == == http://svn.slimdevices.com/slim?view=revision&revision=33212 == Fixed Bug: 17489 Description: don't rely on parsing the title to figure out whether we need to append the artist. Read the pref instead. This fixes issues where titles would lead to invalid regexes in the template.
Created attachment 7427 [details] cool tags
Works fine in r33214 with those test cases, plus a few more. My tags could do with some attention, though. Screensnip attached for your amusement.