Bug 17476 - Composer/conductor not linked from song information
: Composer/conductor not linked from song information
Status: REOPENED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 7.6.0
: PC Other
: -- normal with 3 votes (vote)
: Future
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-20 01:35 UTC by Erland Isaksson
Modified: 2011-11-01 02:33 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erland Isaksson 2011-08-20 01:35:26 UTC
This has been tested with 7.6.1 r33110

When viewing the song details of a song with a composer/conductor in the web interface, composer and conductor are correctly shown but they are just shown as text (not clickable links), to make them clickable links I have to check the  "Composer" and "Conductor" checkboxes in SBS Settings/My Music.

Since the composers and conductors are always in the database, this doesn't make sense, they should always be clickable links from the Song Info page in the web interface independent of settings in SBS Settings/My Music.
Comment 1 Michael Herger 2011-08-22 03:14:33 UTC
This is not limited to the web UI, but the same applies to SP too.
Comment 2 Michael Herger 2011-08-22 03:27:52 UTC
Oh, wait: you'd have to enable the "Composer, Band and Orchestra in Artists" options to make this work. Can you confirm this would work for you too?
Comment 3 Michael Herger 2011-08-22 03:33:50 UTC
http://forums.slimdevices.com/showthread.php?t=89708 - the claim is that even with those options disabled, they should be linked from the song information. I'm pretty sure if we did this, then the next bug report would be "can't find the composer, which is linked from song info"?

I'll give that  a try anyway...
Comment 4 SVN Bot 2011-08-22 03:41:35 UTC
 == Auto-comment from SVN commit #33137 to the slim repo by mherger ==
 == http://svn.slimdevices.com/slim?view=revision&revision=33137 ==

Fixed Bug: 17476
Description: link all contributors from the song info page.

This change might be considered wrong, but as we're trying to display all information available about a track anyway, we can as well link the information we have. This is assuming that un-checking the aforementioned options is intended mainly to keep the main artists list small.
Comment 5 SVN Bot 2011-08-23 22:59:05 UTC
 == Auto-comment from SVN commit #33157 to the slim repo by mherger ==
 == http://svn.slimdevices.com/slim?view=revision&revision=33157 ==

Bug: 17476
Description: reverting change 33137 as it's not working as expected. Unless the xxxInArtists pref is set, the album wouldn't show up in a contributors album list. Eg. you have a conductor with no album of his own, linking from his conductor role would lead to an empty list unless conductorInArtists is set.
Comment 6 Michael Herger 2011-08-23 23:00:52 UTC
I'm not sure this is going to happen. Either you enable those roles to be included in the artists list, or this won't work.
Comment 7 Philip Meyer 2011-08-24 17:24:11 UTC
(In reply to comment #6)
> I'm not sure this is going to happen. Either you enable those roles to be
> included in the artists list, or this won't work.

Am I missing something?

In SBS 7.5.x, I can navigate to a song that has a conductor, click on the conductor artist link and it will show albums with that contributing conductor, even though I have not included conductors in the list of artists.

I don't see why it shouldn't work in 7.6 in a similar way (except show any work that the chosen artist has any involvement on).

NB. I think there is a bug in 7.5 where artists that are conductors only do not get returned in searches.  In 7.6, I can see conductors in search results, but clicking on one shows "empty" (no albums).

i.e. I think we need to find a solution, otherwise Search behaviour is broken too.
Comment 8 ehrlacher 2011-10-31 02:29:02 UTC
Any hope to get this ever fixes.
Sry it sucks!

I have to set the xx In Artist option, which ends me in blowing up my "artist" list by adding a few thousand people who even Can't sing ;)

I wanna have ARTISTS only in my ARTIST list but still be able to click composer's Name from the Song info page!

This has been Part is the SBS "philosophy" and worked up to and with 7.5 .
Why is a working Feature cancelled?
Comment 9 Mike Walsh 2011-10-31 02:50:51 UTC
yet another example of why a "single master list" method BLOWS.  the approach is so lame and antiquated its a joke.  lets users define their own sorts and cycle amonng them.
Comment 10 Philip Meyer 2011-10-31 13:22:37 UTC
(In reply to comment #9)
> yet another example of why a "single master list" method BLOWS.  the approach
> is so lame and antiquated its a joke.  lets users define their own sorts and
> cycle amonng them.

You're wrong.  It's not yet another example of a single master list issue.

Thr reported problem is that irrespective of whether composers/conductors are shown in the list, a composer name should be clickable from Song Info, to be able to see other work by that artist.  

That's how it used to work in 7.5, 7.6 broke it.
Comment 11 Mike Walsh 2011-10-31 13:46:09 UTC
i'm not wrong phil, i'm saying that right now the workaround would be to tick the composers which would blow up the master list.  i agree that 7.6 broke it, but i have yet to hear it will be fixed, and the bigger point is that it wouldn't be an issue IF SBS didn't use such a stupid paradigm to begin with.
Comment 12 Philip Meyer 2011-11-01 01:35:13 UTC
(In reply to comment #11)
> the bigger point is that it wouldn't be an issue
> IF SBS didn't use such a stupid paradigm to begin with.

The suggested workaround is to add the composers to the list of Artists.  But that's just a bug, it never used to be like that.  Irrespective of whether there is a single list of artists, or many configurable custom views, when a user clicks on a Composer name, it should take the user to a page that lists work by that artist (Composer).
Comment 13 Mike Walsh 2011-11-01 02:04:20 UTC
i am seriously not trying to argue with you about this b/c i don't disagree with what you are saying, but i think you are failing to see the point i am making.

if you didn't have a stupid "single master list" paradigm to begin with, then the bug wouldn't be "toggled on" or "toggled off" b/c you wouldn't even need checkboxes in the first place, and the code would be simpler as one would always expect to be able to follow any such link from anywhere, be it artist, album artist, composer, title, whatever, (and in addition you could custom sort by them).

i suspect this bug exists DUE to the code getting its logic confused over what should be included and what shouldn't be, and by extension what qualifies as a followable link and what should just be text.  it certainly would seem thats the case given the behavior of tick = link / no tick = text.
Comment 14 Michael Herger 2011-11-01 02:33:46 UTC
Guys - please stick to facts and discuss your personal opinions elsewhere. Bugs which get flooded with irrelevant topics or wild guesses are likely to be confusing use more than helping you. Thanks!