Bug 1745 - Screensaver data still sent when player brightness == 0
: Screensaver data still sent when player brightness == 0
Status: NEW
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.1.0
: All All
: -- enhancement (vote)
: Future
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-03 03:23 UTC by Max Spicer
Modified: 2011-11-06 23:25 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Patch 1 - handles off case (1.82 KB, patch)
2005-07-04 06:02 UTC, Adrian Smith
Details | Diff
Patch 2 - handles on case (5.39 KB, patch)
2005-07-04 06:03 UTC, Adrian Smith
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Spicer 2005-07-03 03:23:17 UTC
Screensaver data is sent to a SqueezeBox even though the SqueezeBox has its
brightness set to level 0 i.e. no display.  In the case of something like the
RSS screensaver where text scrolls continuously, this means that a considerable
amount of network bandwith is used unnecessarily.  The server should only send
data to players that will display it.
Comment 1 KDF 2005-07-03 03:36:53 UTC
Adrian has done a lot of rework to the display code over the last months.  I may
be misreading some of it, but it would seem possible to turn the update rate
down to zero.  if that is feasible, then a quick test on brightness could then
simply stall all animation from a central location. 

marking as an enhancement, since this is currently working as designed.
Comment 2 Adrian Smith 2005-07-03 10:28:09 UTC
Please try patch on dev list - I think this offers what you are looking for 
Max?  

NB this only covers the off state, not if a screensaver is activated during 
while the player is on.  [I think the off case is the one you are interested 
in Max?]
Comment 3 Adrian Smith 2005-07-04 06:02:52 UTC
Created attachment 594 [details]
Patch 1 - handles off case
Comment 4 Adrian Smith 2005-07-04 06:03:27 UTC
Created attachment 595 [details]
Patch 2 - handles on case
Comment 5 Adrian Smith 2005-07-04 06:06:33 UTC
Just attached two patches.
Patch 1 - should handle the specific case Max discussed on the descuss list - 
i.e. the ability to have Rss running as the off screensaver, but stop it 
running if brightnesss is set to 0.  In this case no screensaver is initiated 
if brighness is 0.  If a screensaver is running it is cancelled when 
brighteness is set to zero.

Patch 2 - adds a new 'blank' mode to enable the same function for brightness 
== 0 when the player is not 'off'.  This also includes Patch 1.
Comment 6 Chris Owens 2010-05-06 15:54:32 UTC
Dean doesn't work here any more :)
Comment 7 Adrian Smith 2010-05-07 11:12:05 UTC
I suspect these patches have been superceeded by changes to screensaver to make Boom's volume mode work etc.

Suggest this is moved to Wontfix
Comment 8 Alan Young 2011-11-06 23:25:04 UTC
Unassigned bugs cannot have a priority.