Bug 17364 - Songs with empty "Album" mp3-tag do not appear for Artist
: Songs with empty "Album" mp3-tag do not appear for Artist
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 7.6.0
: PC Debian Linux
: P3 normal with 2 votes (vote)
: 7.6.1
Assigned To: Andy Grundman
: onebrowser
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-28 08:28 UTC by Mark Wahl
Modified: 2011-08-25 12:19 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments
A mp3-file with Title, Artist but empty Album (40.00 KB, audio/x-mp3)
2011-07-29 05:07 UTC, Mark Wahl
Details
Money for nothing by String/Knopfler (17.43 MB, application/octet-stream)
2011-07-30 01:51 UTC, michael123
Details
Navigate to an artist that has a "No Album" album in 7.6.1 (212.68 KB, image/jpeg)
2011-08-16 12:42 UTC, Philip Meyer
Details
Navigate to an artist that has a "No Album" album in 7.5 (62.44 KB, image/jpeg)
2011-08-16 12:43 UTC, Philip Meyer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wahl 2011-07-28 08:28:02 UTC
After upgrade to 7.6.0 (Linux, Debian Lenny) I noticed some Artists in the database without any data. After further investigation I found that songs with an empty "Album" mp3-tag does not appear for Artist. Before 7.6.0 there was displayed a pseudo-album called "Kein Album" which contained the album-less songs. When you directly search for the song, you will find it, so it is in the database. But it is not connected to the artist like in previous releases.
Comment 1 Michael Herger 2011-07-29 04:35:44 UTC
Mark - could you please upload such a file?
Comment 2 Mark Wahl 2011-07-29 05:07:22 UTC
Created attachment 7355 [details]
A mp3-file with Title, Artist but empty Album

I prepared a sample file which leads to the problem. Search for artist "htmltutorial". You will find it. But there is no content for this artist.
Search for title "yippee" and you will get the Song. If this is important: I am using german language for Web-UI and Players.
Comment 3 Michael Herger 2011-07-29 22:24:33 UTC
*** Bug 17370 has been marked as a duplicate of this bug. ***
Comment 4 Philip Meyer 2011-07-29 23:56:59 UTC
I have this problem too.  More information, copied from bug 17370:

I am seeing significantly more artists in the Browse Artists list, all of my
artists that only appear on singles.

Previously, all songs without an album tag got put into an album called "No
Album".  This album was available within "Home > Artists > Various Artists > No
Album" or "Home > Albums > No Album".

Additionally, navigating to a specific artist would also show a "No Album"
entry, which only lists songs without an album for that artist.

This doesn't appear to be happening any more, and as a result there are
additional artists appearing in the artist list, and when I navigate into one,
there are no albums.
Comment 5 michael123 2011-07-30 01:51:39 UTC
Created attachment 7360 [details]
Money for nothing by String/Knopfler

I see "Money for Nothing (Knopfler, Sting)" in the songs view, and I see "Knopfler, Sting" in the artist view, but when I click on the artist, I get an empty screen..
Comment 6 Andy Grundman 2011-08-10 22:03:51 UTC
The database looks correct with a valid No Album entry and links, so I think this is a onebrowser bug.
Comment 7 SVN Bot 2011-08-10 22:23:47 UTC
 == Auto-comment from SVN commit #33044 to the slim repo by agrundman ==
 == http://svn.slimdevices.com/slim?view=revision&revision=33044 ==

Fixed bug 17364, alter the albums->contributors join when looking for a contributor id, so No Album is found properly
Comment 8 Philip Meyer 2011-08-11 00:18:40 UTC
This is a bit better, but not fixed.

My "Browse Artists" list still contains all artists; it should only include artists that have albums, and not include artists that only have "No Album".

e.g. I have a single track by "10,000 Maniacs".  This artist now appears in the artists list.  When I navigate to that artist, it shows a "No Album".

When I browse into "Artists > 10,000 Maniacs > No Album >", I get a massive list of all artists that have a song without an album.  In the Web UI, it's so long, I can't even see the track(s).

When browsing to an artist that has albums and a No Album, the No Album entry should only show songs for that artist, not all artists that have songs without an album.
Comment 9 Philip Meyer 2011-08-11 00:24:10 UTC
Also, I cannot find "No Album" within the Albums list, nor within "Artists > Various Artists > No Album", which used to list all songs that are not on any album.
Comment 10 Jim McAtee 2011-08-11 01:02:43 UTC
(In reply to comment #8)
> When I browse into "Artists > 10,000 Maniacs > No Album >", I get a massive
> list of all artists that have a song without an album.  In the Web UI, it's so
> long, I can't even see the track(s).

That would be bug 17340, although it's fixed for compilation albums. Only non-compilations still display the list of track artists, which needs to be fixed. Is that album being seen as a non-compilation for some reason? It would also explain why you have these artists in your artist list and why it doesn't appear under Various Artists.
Comment 11 Philip Meyer 2011-08-11 12:54:42 UTC
> > When I browse into "Artists > 10,000 Maniacs > No Album >", I get a massive
> > list of all artists that have a song without an album.  In the Web UI, it's so
> > long, I can't even see the track(s).
> 
> That would be bug 17340, although it's fixed for compilation albums. Only
> non-compilations still display the list of track artists, which needs to be
> fixed. Is that album being seen as a non-compilation for some reason? It would
> also explain why you have these artists in your artist list and why it doesn't
> appear under Various Artists.
>

Yes, "No Album" should be a compilation - it was in 7.5.x.

I can't even find "No Album" in Browse Albums, or by searching for "No Album".

This was reported on my bug 17370, which was closed as a duplicate of this bug, but then this bug has been closed without really completely fixing the issue.
Comment 12 Philip Meyer 2011-08-13 16:43:50 UTC
In MySQL, the album table contains an entry for "No Album", where contributor is the contributor number representing "Various Artists".

In SQLite, this album record has contributor=<NULL>


I'm guessing this makes a difference to the browse queries.
Comment 13 Jim McAtee 2011-08-13 16:53:35 UTC
Are you saying that 7.6.1 with MySQL works correctly, but 7.6.1 with SQLite does not? Or are you comparing 7.6.1 to 7.5?

What about the albums.compilation column for 'No Album'?
Comment 14 Philip Meyer 2011-08-13 17:10:46 UTC
(In reply to comment #13)
> Are you saying that 7.6.1 with MySQL works correctly, but 7.6.1 with SQLite
> does not? Or are you comparing 7.6.1 to 7.5?
> 
Sorry, wasn't clear - was comparing 7.5.x MySQL with 7.6 SQLite.

> What about the albums.compilation column for 'No Album'?
Both 7.5.5 and 7.6 have compilation=1 for "No Album".
Comment 15 Jim McAtee 2011-08-15 15:02:05 UTC
This bug needs to be reopened.

There are still numerous problems with the 'No Album' in 7.6.1. All of these things worked correctly in 7.5:

- The album does not appear anywhere under Browse Albums.

- The album does not appear under 'Various Artists' when browsing artists.

- Artists on the album with no full album in the library are listed under Browse Artists when 'Group compilations' is set. Since the artists are from a compilation album, they should not appear in the list.

- A search for 'no album' fails to find it.
Comment 16 Mark Wahl 2011-08-16 11:49:33 UTC
Tried 7.6.1~33073 and all things which I need are solved:
- "Kein Album" is shown for an artist for which I have songs with empty album tag
- No artist is left with an empty page when selected.
- When I select "Kein Album" for this artist I got all songs of this artist which have an empty album tag.

Contrary to Philip Meyer I want to see all artists even without an album (like it was in 7.5, maybe dependent on configuration?). I can live with listing all artists with "Kein Album" when the song is selected, my list is not too long, it fits the browser page.

So for me the bug is solved. Maybe it is best to write a different bug or reopen an existing one for the other mentionend differences to 7.5.
Comment 17 Jim McAtee 2011-08-16 12:00:51 UTC
(In reply to comment #16)
> - When I select "Kein Album" for this artist I got all songs of this artist
> which have an empty album tag.

That's the only aspect of 'No Album' handling in the user interface that has actually been fixed in 7.6.1.

> Contrary to Philip Meyer I want to see all artists even without an album (like
> it was in 7.5, maybe dependent on configuration?). I can live with listing all
> artists with "Kein Album" when the song is selected, my list is not too long,
> it fits the browser page.

This behavior is controlled by the compilation grouping preference. The problem is that when the pref is set to 'Group compilations' the behavior is wrong.
Comment 18 Philip Meyer 2011-08-16 12:36:22 UTC
> Contrary to Philip Meyer I want to see all artists even without an album (like
> it was in 7.5, maybe dependent on configuration?).
>
There is an option for whether a user wants to see all artists, or hide artists that only appear on compilation albums.

  List compilation albums under each artist
  Group compilation albums together  

In 7.6, whatever option above is chosen, all artists on the "No Album" compilation album are displayed in the list.

> I can live with listing all
> artists with "Kein Album" when the song is selected, my list is not too long,
> it fits the browser page.
>
I can't see any songs in Web UI, because the list of artists that appear on "No Album" is so long, and there's no scrollbar.

> So for me the bug is solved.
The bug is not solved, you're just not concerned about it because it doesn't affect you much.

> Maybe it is best to write a different bug or
> reopen an existing one for the other mentionend differences to 7.5.
I did raise a bug, but it was set as a duplicate of this one!
Comment 19 Philip Meyer 2011-08-16 12:42:39 UTC
Created attachment 7399 [details]
Navigate to an artist that has a "No Album" album in 7.6.1

In Web UI, I navigated to:
Browse Artists > 10,000 Maniacs > No Album.

This shows all songs that include 10,000 Maniacs as a contributor on the album called "No Album".

However, the header part of the page is showing an album artist for "No Album" that is incorrect for the artist that I chose to view, and also shows all contributors that appear on "No Album", in an arbitrary order.

As a result, there's no room to show the songs.
Comment 20 Philip Meyer 2011-08-16 12:43:38 UTC
Created attachment 7400 [details]
Navigate to an artist that has a "No Album" album in 7.5

This is what the same navigation shows in 7.5.6.
Comment 21 Mike Walsh 2011-08-25 12:19:25 UTC
just FYI:

this bug was closed and put into release notes prematurely, but it is being worked on / corrected in:

bug 17370