Bug 17347 - Can't play tracks in multiple sub-folders using Browse Music Folder
: Can't play tracks in multiple sub-folders using Browse Music Folder
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.6.0
: PC Ubuntu Linux
: -- major with 6 votes (vote)
: 7.6.1
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-26 13:40 UTC by Simon Oosthoek
Modified: 2011-08-02 12:02 UTC (History)
7 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Oosthoek 2011-07-26 13:40:40 UTC
Today I saw the upgrade to 7.6.0 via the debian repository.

I was also adding new files today (got a new CD with the mail) and even after completely rescanning the library I can't get it to play by putting them in the playlist via the web interface (http://host:9000/) from the music folder selection method.

this happens only for some directories, I tried adding them via the squeezebox remote (squeezebox I) and I noticed that I can add subdirectories with files, but not the parent directory which only contains directories.
looks like this:
Artist-Title/CD1/[files]
Artist-Title/CD2/[files]

I can't add Artist-Title, but I can add CD1 and CD2 separately.

This is not unusual for double-CD situations, I think.

the server.log mentions this:

[11-07-26 22:20:14.3147] Slim::Utils::Misc::msg (1236) Warning: [22:20:14.3145] Argument "" isn't numeric in addition (+) at /usr/share/squeezeboxserver/HTML/Default/xmlbrowser.html line 411.
[11-07-26 22:20:14.3157] Slim::Utils::Misc::msg (1236) Warning: [22:20:14.3156] Argument "" isn't numeric in addition (+) at /usr/share/squeezeboxserver/HTML/Default/xmlbrowser.html line 185.

I figure this is probably a bug due to not checking some values before trying to add them together, but I've never looked at the code...

I put the severity at major, because this gets in the way of playing some of my music in the usual manner...
Comment 1 Michael Herger 2011-07-26 21:09:53 UTC
The warnings aren't good - should investigate them.

But the lack of playing sub-folders' content is "by design". There's another bug discussing it in too much detail... https://bugs-archive.lyrion.org/show_bug.cgi?id=17199#c23
Comment 2 Michael Herger 2011-07-26 23:39:00 UTC
*** Bug 17351 has been marked as a duplicate of this bug. ***
Comment 3 Jim McAtee 2011-07-26 23:54:21 UTC
Bug 17199 is a rather technical discussion of CLI commands and how onebrowser broke in the CLI and how fixing it had to break Browse Music Folder. Too much detail is right.

All I know is that regular users of BMF are going to have a cow. With the most common directory organizations they can no longer play a two disc album if the discs are in subfolders, can no longer play all albums of an artist, or all albums in a genre if they've organized artists by genre.
Comment 4 artzde 2011-07-27 00:48:02 UTC
(In reply to comment #1)
> The warnings aren't good - should investigate them.
> 
> But the lack of playing sub-folders' content is "by design". There's another
> bug discussing it in too much detail...
> https://bugs-archive.lyrion.org/show_bug.cgi?id=17199#c23

As far i understand how this bug came up there. It was some incompatibility
with iPeng. Inside German discussion Pippin told was not his aim to loose the
feature of playing subfolders breaking and there he did announce some solution
by the cli. He realy did not expect that as solution how the bug
https://bugs-archive.lyrion.org/show_bug.cgi?id=17199#c23 was solved that
developers just take away the feature or crash it.

Read in parts the German discussion there:
https://bugs-archive.lyrion.org/show_bug.cgi?id=17199#c23

When i did open the bug report in the topic
https://bugs-archive.lyrion.org/show_bug.cgi?id=17351 my target was not! to change
the given structure now or the design. My thinking was more to give the feature
back ASAP! How is independent. I am not allone. Some postings show that this is
so important for them that they downgrade the server to 7.5x again.
http://forums.logitech.com/t5/MySqueezebox-com-Squeezebox/is-this-a-joke-New-SBS-7-6-is-no-more-able-to-play-subfolders/td-p/655180

"By design" Artist and Album browsing use the metatags inside the files. so if
there are litle typos in Artist name like ABBA or Abba than you find different
artists or Albums. You no more have the chance to play a complete album.
Because this a lot of Users use their directory structure with subfolders to
listen music. If design do not follow the usabillity of a lot of users than its
the question what should be changed?
Comment 5 Alan Young 2011-07-27 01:45:41 UTC
I have been unable to reproduce this. I can browse to subdirectories of empty intermediate directories using BMF (Web UI and ip3k player UI) and play individual tracks or whole directories. This is on Linux.
Comment 6 Jim McAtee 2011-07-27 01:57:01 UTC
(In reply to comment #5)
> I have been unable to reproduce this. I can browse to subdirectories of empty
> intermediate directories using BMF (Web UI and ip3k player UI) and play
> individual tracks or whole directories. This is on Linux.

Maybe the summary is misleading.

Yes, you can browse to and play subdirectories that contain music files, but you cannot play a parent directory and have it play music in its subdirectories, as you could in the past. For example, if you have music stored /ARTIST/ALBUM/TRACK, you can no longer play all of an artist's albums by playing the ARTIST directory.
Comment 7 Alan Young 2011-07-27 02:16:00 UTC
Well, I can do that. But what I cannot play is Artits/Album when Album includes just subdirs (CD1, CD2).
Comment 8 Alan Young 2011-07-27 02:17:29 UTC
Ah, maybe not
Comment 9 Alexander 2011-07-27 03:09:31 UTC
*** Bug 17349 has been marked as a duplicate of this bug. ***
Comment 10 SVN Bot 2011-07-27 03:44:53 UTC
 == Auto-comment from SVN commit #32902 to the slim repo by ayoung ==
 == http://svn.slimdevices.com/slim?view=revision&revision=32902 ==

Fixed bug 17347: Can't play tracks in multiple sub-folders using Browse Music Folder 
Add play, add and insert item actions to BMF folder result items in BrowseLibrary; use playlistcontrol command to effect these actions.
Remove the special case for the load action for a folder in playlistcontrolCommand. Let load action delegate to playlistXitemCommand the same as other actions for a folder. The special case was only there to facilitate play_index for play-other-songs-in-directory functionality. Extend playlistXitemCommand to take a play_index tagged parameter to handle this case.
Comment 11 Joerg Schwieder 2011-07-27 04:24:57 UTC
I hope this fix means that the play_index case where _only_ the folder content (without subfolders) is being played is still around?
Comment 12 Joerg Schwieder 2011-07-27 04:28:38 UTC
OK, seems to work.
Fine :)
Comment 13 artzde 2011-07-27 04:41:53 UTC
(In reply to comment #11)
> I hope this fix means that the play_index case where _only_ the folder content
> (without subfolders) is being played is still around?

I just hope this means the old functionality is back again and nothing else.

If not, maybee open Bug https://bugs-archive.lyrion.org/show_bug.cgi?id=17199 again
and find other solution? Is this possible?

Seems to work. Thanks Alan :-)