Bug 17343 - Problem with album cover due to %FILE deprecation + SQLite lock
: Problem with album cover due to %FILE deprecation + SQLite lock
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.6.0
: PC Linux (other)
: P3 normal (vote)
: 7.6.1
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-26 04:13 UTC by Nemo
Modified: 2011-08-10 20:49 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
scanner log file (3.74 KB, text/x-log)
2011-07-26 04:13 UTC, Nemo
Details
Patch to correct some bugs in Sb 7.6.0 (1.59 KB, text/plain)
2011-07-28 01:36 UTC, Nemo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nemo 2011-07-26 04:13:29 UTC
Created attachment 7343 [details]
scanner log file

I've upgraded my SB server to the last 7.6.0 and I have problems in scanning my
music files database.

The most important is a side effect due to the deprecation of the %FILE
keyword. I use it for album covers because I use one directory for all mp3
files and another directory for all album covers. In the Advanced Settings >
Formatting, I've set "Artwork" to "%FILE", so the server should search for a
.jpg file in the covers directory with the same name as the .mp3 file. The
filename is the only sure identifier, all other fields are not unique and can
have some special characters. So what can you do to correct this? To my
opinion, %FILE must *NOT* be deprecated.

The second problem is when I do a "Clear library and rescan everything", it
does nothing. I've the message "Progress information from the previous scan is
not available.". For your information "Look for new and changed music" seems to
work well. The scanner log file contains some errors (see attached file)

Joel
Comment 1 Nemo 2011-07-28 01:36:23 UTC
Created attachment 7350 [details]
Patch to correct some bugs in Sb 7.6.0

This is the results of my inverstigation and the associated patch

1) In Utils/Scanner.pm, the string newTrack must be replaced by _newTrack in order to allow complete reindexation

2) In Music/Artwork.pm, you must not cache artwork for the directory otherwise all mp3 files in the directory will have the same artwork ???

3) In Music/TitleFormatter.pm, change the code that handle FILE key to extract it from url attribute

4) I've not solved the SQLite lock problem. I've changed my installation to use MySQL and it works fine. I hope you will keep on proposing the MySQL backend cause I've a limited confidence in SQLite.

Thanks for your great work
Nemo
Comment 2 SVN Bot 2011-08-10 20:49:52 UTC
 == Auto-comment from SVN commit #33040 to the slim repo by agrundman ==
 == http://svn.slimdevices.com/slim?view=revision&revision=33040 ==

Fixed bug 17343, %FILE format was broken