Bug 17302 - Forget this player broken in classic view
: Forget this player broken in classic view
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.6.0
: PC Debian Linux
: -- normal with 1 vote (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-07 06:00 UTC by Ralph Irving
Modified: 2011-07-12 10:01 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Irving 2011-07-07 06:00:05 UTC
When I click "forget this player" in player settings from the classic view, nothing happens.

Works fine from the default web gui.

To reproduce.

Create a stream.mp3 player by pointing xmms, vlc, mplayer, windows media player etc to http://servername:9000/stream.mp3.  Play something, stop the stream and then close the player.

Goto the home screen of the classic web view and click the player settings for the player you just created.  You'll see a section called forget this player after the Reset player preferences button in the player settings with a link to click.

Click it and nothing happens the player remains.

Now go to the default view and select Forget this Player from the player settings and the player disappears.
Comment 1 Adrian Smith 2011-07-08 07:20:07 UTC
Problem looks to me that it is trying to forget the wrong player - it currently forgets the selected player in the right hand playlist panel.  If this is not a disconnected player then the forget command is ignored.

If you set the playlist to the player you want to forget then it will work.
Comment 2 SVN Bot 2011-07-08 07:56:27 UTC
 == Auto-comment from SVN commit #32650 to the slim repo by adrian ==
 == http://svn.slimdevices.com/slim?view=revision&revision=32650 ==

Bug: 17302
Description: ensure we forget the correct player - always send the playerid as player for the forget command
Comment 3 Ralph Irving 2011-07-12 10:01:11 UTC
Confirmed that Adrian's change fixes the issue.