Bugzilla – Bug 17227
saved favorites from 7.5.x do not work in 7.6.0/r32413
Last modified: 2011-05-25 07:19:36 UTC
My saved favorites from 7.5.x do not work in 7.6.0/r32413 after upgrade. I see them in the list, but without thumbnails and clicking on them does nothing
THis might be related to that favorite urls looks differently in 7.6 compared to 7.5: In 7.5: db:album.titlesearch=Album title In 7.6: db:album.title=Album title
Michael - could you please share your favorites.opml file with us?
Created attachment 7283 [details] The non-working Favorites file The last entry (One Hot July) is from 7.6 already and it works
> THis might be related to that favorite urls looks differently in 7.6 compared to 7.5: > In 7.5: db:album.titlesearch=Album title > In 7.6: db:album.title=Album title I just investigated this component of the bug, and found that opml links for "db:album.titlesearch=Album title" format work fine on my system. However, I also found something strange in that if I save a favorite in current, up-to-date 7.6, it saves the favorite as db.album.titlesearch not db.album.title. This is contrary to what's seen in the attachment and what Erland reports in the comments. ??? I have many lines in my favorites.opml file with the exact format of the lines of what's described as not working in the file attached to the bug, and they work correctly for me. saved as favorite while using 7.5: <outline URL="db:album.titlesearch=BACK%20TO%20MINE" icon="music/fcd14686/cover.png" text="Back to Mine" type="audio" /> <outline URL="db:album.titlesearch=HEART" icon="html/images/albums.png" text="Heart" type="audio" /> <outline URL="db:album.titlesearch=IN%20OUR%20BEDROOM%20AFTER%20THE%20WAR" icon="music/4dcbec71/cover.png" text="In Our Bedroom After the War" type="audio" /> saved as favorite while using 7.6: <outline URL="db:album.titlesearch=ARULAR" icon="music/74c8e6ea/cover.png" text="Arular" type="audio" /> <outline URL="db:album.titlesearch=WHEN%20IT%20FALLS" icon="music/299dee41/cover.png" text="when it falls" type="audio" /> <outline URL="db:album.titlesearch=WALTZ%20FOR%20KOOP" icon="music/4cb4ce3f/cover.png" text="Waltz for Koop" type="audio" /> all of my favorites, regardless of when saved, worked when using in 7.6.0...something else must be going on in the failure case, but it's unclear what
Unable to repro. Please provide more reproduction steps.
Michael says it happens in onebrowser branch but not trunk.
== Auto-comment from SVN commit #32467 to the slim repo by ayoung == == http://svn.slimdevices.com/slim?view=revision&revision=32467 == bug 17227: saved favorites from 7.5.x do not work in 7.6.0/r32413 Use title, not titlesearch for Album URL (as used for favorites)
Part of the confusion is that different things were happening for favorites and presets. Presets were getting the new behaviour but favorites still had titlesearch for albums. The change above fixes that.
== Auto-comment from SVN commit #32470 to the slim repo by ayoung == == http://svn.slimdevices.com/slim?view=revision&revision=32470 == Fixed bug 17227: saved favorites from 7.5.x do not work in 7.6.0/r32413 The titlesearch field, or any field created by ignoreCaseArticles, was being created with mixed case and other errors. Improve the efficiency of ignoreCaseArticles() a little as it is used heavily in the scanner.
A full rescan will need to be done and at least some new (recently-created) favorites will not work and will need to be removed manually.