Bugzilla – Bug 17175
All radio buttons are selected in text size setting
Last modified: 2011-04-29 16:26:52 UTC
I'm seeing this on both the Boom and an SB2. The text size can still be changed, but it bumps and there's no change to the radio buttons. Both 7.5.x and 7.6.
Triode: Would you be able to look at this?
I don't remember this, but it looks to be due to the way input choice is used. The most simple fix would be to only update the pref when the item is selected, but this has the downside of not changing the font in real time - i.e. the different font options are all displayed in the current font size and its only when you select it that the font size changes. Try to the following to see this: -- Slim/Buttons/Settings.pm (revision 32341) +++ Slim/Buttons/Settings.pm (working copy) @@ -416,7 +416,12 @@ 'useMode' => 'INPUT.Choice', 'header' => '{TEXTSIZE}', 'headerAddCount' => 1, - 'onChange' => \&setPref, + #'onChange' => \&setPref, + 'onPlay' => \&setPref, + 'onAdd' => \&setPref, + 'onRight' => \&setPref, + 'overlayRef' => sub { return (undef, undef) }, + 'overlayRefArgs' => 'CV', 'pref' => 'activeFont_curr', 'initialValue' => sub { $prefs->client(shift)->get('activeFont_curr') }, 'condition' => sub { $_[0]->display->isa('Slim::Display::Graphics'); }, Does this look better? If not then it will need some more thought...
Opps - ignore the overlayRef entries, it just changing onChange to onPlay/onAdd etc that I propose.
== Auto-comment from SVN commit #32342 to the slim repo by adrian == == http://svn.slimdevices.com/slim?view=revision&revision=32342 == Bug: 17175 Description: use custom change handlers for font setting menu so we can show the font options without always showing a set radio button
Please try 7.6 to see that shows what is desired - I came up with a more complex method of setting the radio buttons. Andy - does this really need to be in 7.5 too?
I'm OK with either 7.5 or 7.6. I picked 7.5.x because I assumed it was a regression.
That looks good to me. I just noticed that in the title format setting there are HASH(...) entries. I don't know if it was doing that previously, but hopefully this change didn't cause that behavior.
Where in the title entries - I don't see this. Which branch?
Same branch. I found why, though. In the web interface I could see that a blank title was selected, so I guess the index was out of range. Probably the results of copying a server.prefs file or manually editing title formats. My bad.
== Auto-comment from SVN commit #32349 to the slim repo by adrian == == http://svn.slimdevices.com/slim?view=revision&revision=32349 == Bug: 17175 Description: merge fix from 7.6 -r 32341:32342
Verified on 7.6 32376 on SB Boom and SB Classic