Bugzilla – Bug 17085
Random Mix 1.0 misbehaves when told to "stop adding albums"
Last modified: 2011-05-12 15:40:22 UTC
When I play "Random albums" all is well. However, if I click "stop adding albums" in the web ui, SBS finishes playing the current album, and then it starts adding random songs. This behaviour is not immediately reflected in the Random Play part of the web ui; you just see random songs appearing "out of nowhere" at the bottom of the playlist. But if you refresh the web browser after the random songs have started appearing, you'll get the link to "stop adding songs". I first noticed this behaviour in SBS 7.6 beta in December 2010, and it's still present, after several SBS updates. My current SBS Version: 7.6.0 - r32137 (Win7). The plugin responsible for this I guess is Random Mix 1.0. And BTW: If you choose "Empty current playlist" in the SBTouch "Currently playing" playlist, the same thing happens. That's how I originally stumbled upon this bug. I emptied the playlist, and expected to see a new random album; instead I got random songs. But the problem seems to be with the plugin and not the Touch, because the same behaviour is seen when clicking "stop adding albums" in the SBS web ui.
Yes, I see this in both 7.6 trunk and onebrowser. If you clear the playlist then after a short (occasionally long) delay it starts up again in Random songs mode. For me, it doesn't begin playing the music, it just loads tracks into the current playlist. If I begin playback I can see that it's in Random songs mode by the way it adds and removes songs from the playlist. I find that it does this playing either 'Random albums' or 'Random songs'. The number of songs it always loads is 'N upcoming songs' + 1.
I can't reproduce this - could you retry with r32351 or later and give me more steps to reproduce if you still see this.
Looks like 32351 fixes this. With any version prior to 32351 it happens if you clear the playlist after a track change, but before the additional tracks are added. When you clear the playlist after the tracks are added then it stays cleared.
Ok - thanks, 32351 is more careful to kill any pending timers when I thought they were no longer required and I thought may fix this. Sounds like it does... Will mark as closed
7.6.0 r32407 -- Able to do Random Mix of albums and clear or 'stop adding' without error