Bug 17029 - Networking::SqueezeNetwork::Players:: disconnect_player() broken for SP-Hardware players
: Networking::SqueezeNetwork::Players:: disconnect_player() broken for SP-Hardw...
Status: RESOLVED DUPLICATE of bug 15396
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.6.0
: All All
: P2 normal with 1 vote (vote)
: 7.6.0
Assigned To: Michael Herger
: patch_waiting
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-05 23:21 UTC by Gordon Harris
Modified: 2011-05-30 00:45 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
Patch which fixes this bug. (577 bytes, patch)
2011-03-05 23:21 UTC, Gordon Harris
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Harris 2011-03-05 23:21:26 UTC
Created attachment 7192 [details]
Patch which fixes this bug.

Since SBS 7.4 was released,
Slim::Networking::SqueezeNetwork::Players::disconnect_player() hasn't worked
with any of the SqueezePlay based hardware: SBTouches, SBRadios, SBControllers.
 The effect of this has been to break the 'disconnect aa:bb:cc:dd:ee:ff
www.mysqueezebox.com' interface as well as the SBS webUI's abiltiy to fetch
back SP-based hardware players.

If Line 348 in Players.pm:

$http->get( $http->url( '/api/v1/players/disconnect/' . $id . '/' . $ip ) );

..is replaced with:

$http->post( $http->url('/jsonrpc.js'), 'Content-Type' => 'application/json',
to_json({
        id     => 1,
        method => 'slim.request',
        params => [ $id, ['connect', $ip] ]
    }) );

..so that the disconnect request to mysb.com is made via jsonrpc, this fixes
both the CLI problem and the webUI problem.

I've successfully tested this fix with the following hardware:

SBClassic
SBBoom
SBReceiver
Transporter
SBController
SBTouch
SBRadio

It would be nice if this fix could be back-ported to 7.5.4 too.
Comment 1 Michael Herger 2011-05-30 00:45:06 UTC

*** This bug has been marked as a duplicate of bug 15396 ***