Bug 1702 – checking formats could be more optimised

Bug 1702 - checking formats could be more optimised

Summary:

checking formats could be more optimised

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Formats
Version:	6.1.0
Platform:	All All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Vidur Apparao

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-06-21 23:52 UTC by KDF
Modified:	2008-09-15 14:37 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
before (6.45 KB, text/plain) 2005-06-21 23:53 UTC, KDF	Details
after (2.25 KB, text/plain) 2005-06-21 23:54 UTC, KDF	Details
patch to get from before to after (854 bytes, patch) 2005-06-21 23:55 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description KDF 2005-06-21 23:52:44 UTC

I always notice the huge amount of text when we start playback using d_source. 
This shows a lot of activity for checking formats that I'm sure isn't needed. 
Its fast, but so easily faster.  We check profiles, then check that its enabled
and then check for binaries.  What would be faster is to only bother to check if
its enabled/binaries if there is a valid command to care about.

In my test, this reduced the time from 12ms to 7ms.

patch and test logs coming soon

Comment 1 KDF 2005-06-21 23:53:29 UTC

Created attachment 560 [details]
before

shows the time from open song to valid command and open song.  really chatt no?

Comment 2 KDF 2005-06-21 23:54:39 UTC

Created attachment 561 [details]
after

now, we check profiles and just skip the rest if there is no entry found. no
entry, no care if its officially enabled or not and no care about binaries.

Comment 3 KDF 2005-06-21 23:55:36 UTC

Created attachment 562 [details]
patch to get from before to after

just a small shift in tests and we skip a few steps when we have found that
there is no entry to care about.

Comment 4 Vidur Apparao 2005-06-23 15:42:37 UTC

Looks good to me. Go with it.

Comment 5 Chris Owens 2006-06-16 14:41:20 UTC

There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.