Bug 1701 - Don't add playlist file contents to playlist when adding whole directory
: Don't add playlist file contents to playlist when adding whole directory
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.1.0
: All Linux (other)
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-06-21 11:59 UTC by Robin Bowes
Modified: 2008-09-15 14:36 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Bowes 2005-06-21 11:59:31 UTC
When browsing the music folder, playlist files (e.g. .cue and .m3u) show up in
the listing. If you click > or + against "All subfolders", the files in the
directory get added, but also the files listed in the playlist files get added too.

Default behaviour should be that playlist files do not get added to the playlist
unless they are clicked on explicitly.
Comment 1 KDF 2005-06-21 12:55:32 UTC
and here I was thinking that add all was for adding all...
Comment 2 Robin Bowes 2005-06-21 13:52:11 UTC
Ah well, you know what thought did...
Comment 3 Dan Sully 2005-06-25 10:34:55 UTC
Robin - this should be fixed now.
Comment 4 Robin Bowes 2005-06-25 11:36:21 UTC
Hmmm. In what way is it "fixed" ?

I've just updated to r3557 and the behaviour doesn't seem to have changed.

What behaviour should I now expect?

R.
Comment 5 KDF 2005-07-13 02:14:28 UTC
This seems to work from playerUI, but not webUI.
adding a folder from playerUI, however, seems to come up in the current playlist
with a lot of missing metadata for all but song1.  
adding from webUI shows all metadata, but is adding the entire playlist if one
exists in the folder
Comment 6 Dan Sully 2005-07-19 13:59:33 UTC
Robin - this is too risky of a fix to try for 6.1  - as a work around, can you move your playlists out of the 
audiodir?
Comment 7 Dan Sully 2005-07-19 16:21:56 UTC
Robin - can you try this patch?

--- Slim/Utils/Scan.pm  (revision 3028)
+++ Slim/Utils/Scan.pm  (local)
@@ -636,7 +636,7 @@
                                });
                        }
 
-               } else {
+               } elsif (Slim::Utils::Misc::inPlaylistFolder($playlisturl)) {
Comment 8 Robin Bowes 2005-07-20 23:43:26 UTC
Dan,

I've tried your patch and it seems to work.

After applying the patch, I used "Browse Music Folder" to browse to an album 
listing and clicked "+" to add the contents to the current (empty) playlist. 
All the music (flac) files were added but the two .m3u files in the directory 
were ignored.

R.
Comment 9 Dan Sully 2005-08-14 17:05:18 UTC
Robin - I've checked in a slight variation of the patch as subversion change 3969