Bug 16908 – ALAC fixed at 44100/2/16 & poor error handling

Bug 16908 - ALAC fixed at 44100/2/16 & poor error handling

Summary:

ALAC fixed at 44100/2/16 & poor error handling

Status:	CLOSED FIXED

Product:	SqueezePlay
Classification:	Unclassified
Component:	Audio
Version:	unspecified
Platform:	Other Debian Linux

Importance:	P2 major (vote)
Target Milestone:	7.6.0
Assigned To:	Bradley D. Wall

URL:
Keywords:

Depends on:
Blocks:	16903
	Show dependency tree / graph

Reported:	2011-02-07 09:27 UTC by Alan Young
Modified:	2011-05-11 16:45 UTC (History)
CC List:	2 users (show)

See Also:
Category:	Bug

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alan Young 2011-02-07 09:27:58 UTC

The built-in ALAC CODEC (not currently used when running SbS on any system other than SB Touch) is hardwired for 44100/2/16 and does not detect or react to other stream characteristics.

The error handling is poor or non-existent in other cases.

The MP4 parsing of box lengths is flawed: incorrectly deals with the special 0 and 1 cases and treats an empty box as having infinite length.

Comment 1 SVN Bot 2011-02-08 03:07:49 UTC

 == Auto-comment from SVN commit #9304 to the jive repo by ayoung ==
 == http://svn.slimdevices.com/jive?view=revision&revision=9304 ==

bug 16908: ALAC fixed at 44100/2/16 & poor error handling 
Fix parsing of special box lengths 0 and 1.

Comment 2 SVN Bot 2011-02-08 03:08:54 UTC

 == Auto-comment from SVN commit #9305 to the jive repo by ayoung ==
 == http://svn.slimdevices.com/jive?view=revision&revision=9305 ==

bug 16908: ALAC fixed at 44100/2/16 & poor error handling 
Parse number of channels and sample-rate from metadata.
Improve error-handling
Add 24-bit support.

Comment 3 SVN Bot 2011-02-09 07:44:16 UTC

 == Auto-comment from SVN commit #9312 to the jive repo by ayoung ==
 == http://svn.slimdevices.com/jive?view=revision&revision=9312 ==

bug 16908: ALAC fixed at 44100/2/16 & poor error handling 
Correct number-of-frames calculation.

Comment 4 Bradley D. Wall 2011-05-11 16:45:33 UTC

Closing.  using 7.6.0 32398, and an SB Touch (7.6.0, r9430), sent various bit streams through device and had no errors or failures as described. Closing.