Bug 16748 - Nodes added by JiveMain to home node are showing EN string regardless of locale
: Nodes added by JiveMain to home node are showing EN string regardless of locale
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: UI
: 7.5.x
: PC Other
: P1 critical with 3 votes (vote)
: 7.6.0
Assigned To: Ben Klaas
http://forums.slimdevices.com/showthr...
:
Depends on:
Blocks: 17154
  Show dependency treegraph
 
Reported: 2010-12-23 12:19 UTC by Ben Klaas
Modified: 2011-05-03 14:47 UTC (History)
2 users (show)

See Also:
Category: Bug


Attachments
screenshot of various JiveMain nodes being added to 'home' (73.44 KB, image/png)
2010-12-23 12:32 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2010-12-23 12:19:47 UTC
This is a regression and needs to be fixed before 7.6 is released

from the forums:
"While playing around with SBS 7.6, which updated my controller to 7.6 as
well, I noticed that the 'Choose Player' and 'Settings' menu items in
the controller main menu are no longer localized, but stay in English.
This situation also doesn't change when triggering a language switch. I
verified that really the EN string is used by replacing that string."

My own debug shows that this only happens for those nodes added by JiveMain to the home node, not a sub-node. For example, if I put ADVANCED_SETTINGS on the node 'home', it remains EN. When it's in the node 'settings', it gets properly translated.

Suspicion was that changes to CustomizeHomeApplet that are in 7.6 were the cause, but after disabling this applet the bug remained. I looked through JiveMain.lua, locale.lua, and SetupLanguageApplet files and none of that code has changed between 7.5 and 7.6.

Right now the root cause of the regression is a complete mystery, but it needs fixing.
Comment 1 Ben Klaas 2010-12-23 12:32:16 UTC
Created attachment 7066 [details]
screenshot of various JiveMain nodes being added to 'home'

I hacked JiveMain to take a bunch of the sub-nodes of settings (which are properly localized in these submenus) and put them on the top of the home menu.

Results are inconsistent:
Advanced, Beta Features, and Screen show EN string
Factory Test and Networking show DE string

????
Comment 2 Ben Klaas 2011-04-14 14:26:58 UTC
no solution yet, but here's some more findings:

the global strings file is read in with the default language EN when JiveMain is initially run, including when nodes e.g. Settings are added

the global strings file is read in with the user-configured language when the registerApplet method in SetupLanguageMeta is run (very soon after JiveMain)

when that second load happens, some of those nodes are not getting updated to reflect the language change.

This is a bad regression and I'm still without conclusion as to its origin.
SetupLanguage and locale code hasn't changed in years. No change in JiveMain either that should have affected this.
Comment 3 SVN Bot 2011-04-15 15:09:29 UTC
 == Auto-comment from SVN commit #9425 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=9425 ==

Fixed Bug: 16748
Description: specialized homeMenuText for nodes in the home menu was screwing up the localization code
opt to punt and use the same text for when items are customized the home menu 
this is the lesser of two evils: text that's slightly out of context (e.g., "Artists" instead of "Browse Artists") rather than
text that is in the wrong language
Comment 4 Paul Chandler 2011-05-03 14:47:39 UTC
Added items to Home Menu (after setting the language to German) on the Jive controller

All items retained the German language