Bugzilla – Bug 16671
preset_data loop in playerstatus may have broken playerstatus updates for some players
Last modified: 2011-05-09 09:36:56 UTC
users in forum reporting that Now Playing window is showing just text of "Nothing" on screen after updating to 31538 from 31534. Reverting to 31534 fixes the issue. Only candidate amongst those 4 checkins causing this failure is 31537, which adds preset_data loop to the playerstatus response generated from Slim::Queries::statusQuery().
Created attachment 7042 [details] do extra checking on presets data structure before populating presets_data loop without reproducing the issue yet, this is a bit of a longshot, but this patch includes extra checking to make sure that $presets is an arrayref and each defined element in the array are hashrefs.
== Auto-comment from SVN commit #31548 to the slim repo by bklaas == == http://svn.slimdevices.com/slim?view=revision&revision=31548 == Bug: 16671 Description: check that the returned data structure for presets data is appropriate for sending out to the player
== Auto-comment from SVN commit #31549 to the slim repo by adrian == == http://svn.slimdevices.com/slim?view=revision&revision=31549 == Bug: 16671 Description: fix typo which causes this code to fail
I think we're okay on this one now