Bug 16620 - SBS 7.6, new artwork resizing, "F" option doesn't seem to work
: SBS 7.6, new artwork resizing, "F" option doesn't seem to work
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Artwork
: 7.6.0
: PC Other
: P2 critical with 2 votes (vote)
: 7.6.0
Assigned To: Joerg Schwieder
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-18 18:32 UTC by Joerg Schwieder
Modified: 2011-05-12 10:16 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joerg Schwieder 2010-10-18 18:32:10 UTC
I use
"/music/...../cover_768x768_F_000000"
to download the big artwork for the NowPlaying screen in iPeng for iPad (and similar commands in other iPeng versions).

"F" is supposed to mean that I get a _downscaled_ version of a cover if the original file had a higher resolution than requested and the original size whenever the file had a lower resolution.

In current SBS 7.6 builds this will always return an image sized 768x768 (minus cropping) even if the original file was smaller.
Comment 1 Andy Grundman 2010-10-18 18:49:46 UTC
Hmm, some of those options were removed when I switched from GD to Image::Scale.  Wasn't aware anyone used this one.
Comment 2 Joerg Schwieder 2010-10-19 00:08:52 UTC
The problem is "F" is the one that clearly makes most sense for higher resolutions. iPad and iPhone can scale pretty well themselves and there is little sense to send an upscaled 768x768 (or even worse, the 960x960 used on iPhone 4!) image over the network if it's really just 128x128.
Comment 3 Michael Herger 2011-01-21 01:36:28 UTC
Andy - this is a real issue: the new artwork handler is upscaling all artwork if requested larger than original. This is definitely killing usability on eg. a ReadyNAS which can see the CPU pegged for 30-50s when requesting such a file. I'd expect this to be an issue for fab4 too.

I wouldnt't be surprised if some of the "playback cuts out at the beginning of the track" reports were related to this.
Comment 4 SVN Bot 2011-04-26 04:15:46 UTC
 == Auto-comment from SVN commit #32345 to the slim repo by fmueller ==
 == http://svn.slimdevices.com/slim?view=revision&revision=32345 ==

Bug: 16620 
Description: Add 'F' option to GDResizer - return original if requested size is bigger, return downsized if requested size is smaller
Comment 5 Bradley D. Wall 2011-05-06 14:08:05 UTC
Can this be closed or the severity changed?
Comment 6 Mickey Gee 2011-05-09 09:40:48 UTC
Joerg, can you confirm the fix?
Comment 7 Joerg Schwieder 2011-05-09 09:55:22 UTC
Looks OK for what I can see here.
Tested 7.6 trunk.
Comment 8 Bradley D. Wall 2011-05-12 10:16:00 UTC
Closing per Joerg's comments.