Bug 1659 - Pressing PLAY when should work for contributors as well as artists
: Pressing PLAY when should work for contributors as well as artists
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.1.0
: Macintosh All
: P2 enhancement (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-06-11 14:33 UTC by Blackketter Dean
Modified: 2009-09-08 09:11 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
use loadtracks on album->id() (1.52 KB, patch)
2005-08-13 11:13 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2005-06-11 14:33:16 UTC
 
Comment 1 KDF 2005-06-24 23:41:59 UTC
I think something is missing here.  Navigating into track info from now playing,
or all the way down through browse music and finding the album item seems to
report in the message that it is now playing from 'album' and loads the album as
the new playlist.  

Comment 2 Vidur Apparao 2005-06-30 15:40:49 UTC
KDF, are you saying this works? Either way, moving this forward.
Comment 3 KDF 2005-06-30 15:43:42 UTC
It works for me, but I saw nothing that showed any sort of fix to make this
work, so I wondered if perhaps I was misunderstanding the exact problem.

I think Dean needs to just test it once more with a recent build to be sure :)
Comment 4 Blackketter Dean 2005-07-03 13:07:02 UTC
This seems to only be an issue with compilation albums.
Comment 5 KDF 2005-08-09 15:10:10 UTC
looking at the d_command output, it seems the play command refers to artist AND
album, which might explain why compilations fail:

2005-08-09 15:09:04.7021  Executing command f0:5a:f4:24:93:98: playlist
(loadalbum) (Punk Rock) (GREEN DAY) (American Idiot) () () ()
2005-08-09 15:09:04.7882  Returning array: playlist (loadalbum) (Punk Rock)
(GREEN DAY) (American Idiot) () () ()

ignoring artist would go back to the greatest hits problem, but Dan's recent
addition of albumartist should allow this to work.  I'm not sure what kind of
changes have to be made yet, however.
Comment 6 KDF 2005-08-13 11:13:01 UTC
Created attachment 722 [details]
use loadtracks on album->id()

altered trackinfo to be a bit more like browseDB for playing the album.  the
question is, does this still need the contributor.role?

artist and title can probably be converted as well, since the old wildcard
method is, well, older :)
Comment 7 Dan Sully 2005-08-13 11:28:00 UTC
Looks good. And yes, it should be done for the others as well.
Comment 8 KDF 2005-08-13 12:23:57 UTC
having an issue converting the rest.  genre is ok, artist is like this so far:

	} elsif ($item =~ /^(?:ARTIST|COMPOSER|CONDUCTOR|BAND)$/) {

		my $lcItem = lc($item);

		$line2 = $track->$lcItem();
use Data::Dumper;
print Dumper($track->$lcItem());
		push @search, "contributor=".$track->artist()->id();

however, line2 is coming out as "1", while the dump shows:
$VAR1 = bless( {
                 'id' => '950'
               }, 'Slim::DataStores::DBI::Contributor' );

I think I'm missing a context shift somewhere.
Comment 9 KDF 2005-08-14 14:34:14 UTC
patch committed to change 3963

contributors other than artist were also broken, so I have only enable artist
for now.  composer, as one example comes up with the symptoms described in the
previous comment.  $line2 gets "1", while a dump shows that it should be a
contributor object.  However, calling an ->id() on it will crash. Even trying to
take that contributor id, treating it like an artist id, doesn't seem to work
right either.

changing this to an enhancement to deal with the rest of this, since I don't
seem to see any similar handling for composer/band, etc elsewhere.
Comment 10 Dan Sully 2005-09-13 15:18:29 UTC
Large Various Artists / Multiple Artists in Tags update checked in as subversion change 4258.