Bug 16554 - of multiple artists in tag 'artist' only one shown on controller nowplaying screen
: of multiple artists in tag 'artist' only one shown on controller nowplaying s...
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Controller
: 7.6.0
: PC Ubuntu Linux
: P2 normal with 8 votes (vote)
: 7.6.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-16 13:13 UTC by win.srisk@planet.nl
Modified: 2014-08-05 19:49 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments
code snippet from Control::Queries.pm, with added log statements (2.40 KB, text/plain)
2010-09-16 13:13 UTC, win.srisk@planet.nl
Details
log file with original tags (5.98 KB, text/plain)
2010-09-16 13:15 UTC, win.srisk@planet.nl
Details
log file with tags A and in reversed order (6.06 KB, text/plain)
2010-09-16 13:16 UTC, win.srisk@planet.nl
Details
flac file showing tags that cause random artist display (761.99 KB, application/octet-stream)
2011-07-27 01:54 UTC, Phil Leigh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description win.srisk@planet.nl 2010-09-16 13:13:57 UTC
Created attachment 6969 [details]
code snippet from Control::Queries.pm, with added log statements

I have a lot of classical music. I use flac files with 'composer' tag for
composer, and put performers in tag 'artist'. When there are multiple artists,
only one of them is shown in the Controller Now Playing screen. 

I have traced this back to the Control::Queries.pm module in Squeezeboxserver.

Song information is retrieved in sub _addJiveSong {, using tags 'AalKNcx' to
retrieve track information. Because tag 'a' is used after tag 'A', the multiple
artist information, which is retrieved using tag 'A' is overwritten with the
Artist information using tag 'a'.

See attached code snippet, with added log statements, and two log files, one
with tags 'AalKNcx', and one with tags 'aAlKNcx'.
Comment 1 win.srisk@planet.nl 2010-09-16 13:15:39 UTC
Created attachment 6970 [details]
log file with original tags
Comment 2 win.srisk@planet.nl 2010-09-16 13:16:28 UTC
Created attachment 6971 [details]
log file with tags A and in reversed order
Comment 3 Jim McAtee 2011-06-29 13:05:25 UTC
I believe this bug exists in all interfaces. See the forum thread:

http://forums.slimdevices.com/showthread.php?t=88473
Comment 4 Jim McAtee 2011-06-29 19:51:44 UTC
This bug is also apparent in several other places. When browsing albums, if the album is a non-compilation attributed to two artists, only one of them is displayed. And when viewing track listings album, only one artist is displayed.
Comment 5 ehrlacher 2011-07-25 13:48:07 UTC
If You fix this bug - please fix the "album artist/track artist/composer" mixture too - it makes SBS / LMS nearly unusuable ... even "Windows Media Player" makes it to see those as different tags...
Comment 6 Mike Walsh 2011-07-25 14:04:01 UTC
i've been singing that song for years comment 5

right you are, but don't hold your breath!
Comment 7 SVN Bot 2011-07-25 21:17:32 UTC
 == Auto-comment from SVN commit #32860 to the slim repo by mherger ==
 == http://svn.slimdevices.com/slim?view=revision&revision=32860 ==

Fixed Bug: 16554
Description: get contributors after the artist to not overwrite contributor list with single artist.

Thanks guys!
Comment 8 Phil Leigh 2011-07-26 12:41:16 UTC
(In reply to comment #7)
> == Auto-comment from SVN commit #32860 to the slim repo by mherger ==
>  == http://svn.slimdevices.com/slim?view=revision&revision=32860 ==
> 
> Fixed Bug: 16554
> Description: get contributors after the artist to not overwrite contributor
> list with single artist.
> 
> Thanks guys!

Not sure how you can claim this is closed when nobody except you (hopefully) has tested it!

I look forward to 32860 arriving...
Comment 9 Jim McAtee 2011-07-26 12:46:48 UTC
I've tested it and from what I can tell it looks good. I believe it just implemented the OP's suggested change.

Too bad this didn't make it into the 7.6.0 release.
Comment 10 Jim McAtee 2011-07-26 15:19:29 UTC
Ok, I do still see a problem with the artist(s) shown for albums. When there are multiple ARTISTs and no ALBUMARTIST, then SBS only lists a single artist.

For tracks, it appears to be correct. With or without an ALBUMARTIST I see a list of all of the track artists.

Please reopen.
Comment 11 Michael Herger 2011-07-26 21:03:48 UTC
> Ok, I do still see a problem with the artist(s) shown for albums. When there
> are multiple ARTISTs and no ALBUMARTIST, then SBS only lists a single artist.
> 
> For tracks, it appears to be correct. With or without an ALBUMARTIST I see a
> list of all of the track artists.

That would describe Frank's issue (for which I got a test file).
Comment 12 Michael Herger 2011-07-27 01:12:27 UTC
*** Bug 17346 has been marked as a duplicate of this bug. ***
Comment 13 Phil Leigh 2011-07-27 01:54:51 UTC
Created attachment 7346 [details]
flac file showing tags that cause random artist display

please see forum post :http://forums.slimdevices.com/showthread.php?p=643643#post643643
Comment 14 SVN Bot 2011-07-27 05:19:39 UTC
 == Auto-comment from SVN commit #32905 to the slim repo by mherger ==
 == http://svn.slimdevices.com/slim?view=revision&revision=32905 ==

Bug: 16554
Description: some more artist tweaking
- web: don't mess with artist information in the template, but format search results differently from the beginning
- SP: don't use the titleformat for search results, but return the title only, as additional information is shown on a second line anyway
Comment 15 ehrlacher 2011-07-28 16:43:31 UTC
Ok, I can see first step is done and it's a BIG step and MANY thanks to michael for his good work.

But there is still the fatal mixture between composer, artist and album artist.

No matter if I click on

artist: Wolfgang Herrmann
album artist: Wolfgang Herrmann
composer: Wolfgang Herrmann

ALL 3 links point to

http://127.0.0.1:9000/clixmlbrowser/...mann)/&player=

and give the same results of course.

I call it "broken" for it worked fine up till 7.5 inkl.

I will show You with one example why the actual beahviour of SBS/LMS is completely "nonsens":

Wolfgang Herrmann is a well-known german composer (in first) who sings some songs himself.

So I own:
3 albums of Wolfgang Herrmann "singing" (album artist + (track) artist)
20 sampler with songs of Wolfgang Herrmann singing on it (artist / track artist)
100 albums/sampler with songs he composed on them.

So I would expect:
clicking "album artist: Wolfgang Herrmann" only giving those 3 results
clicking "artist: Wolfgang Herrmann" giving about 23 results (all albums with songs on them he is actually SINGING)
clicking "composer: Wolfgang Herrmann" about 123 results, containing all the songs he composed (most of the songs he sung he composed himself).

BUT
in every case I gett ALL 123 results.

So when I click "album artist: Wolfgang Herrmann" or "artist: Wolfgang Herrmann" I expect to see the songs where I can "hear his voice"  - but about 98% of the results are wrong, for on those albums he didn't sing a single note, he only composed songs for them. Eg I see a sampler with 40 songs, one of them he composed sung by s.o. else ... it's even difficult to imagine for s.o. who uses this link, WHY SBS has selected this album, on first view doesn't seem to be connected with him .. 

.. .I hope You see the problem as I see or to cut a long story short:

SBS still ignores the "role" model of the database... (and I had a look, it's still in the db ..)
Comment 16 win.srisk@planet.nl 2011-07-29 15:23:07 UTC
I can confirm that bug 16554 has been resolved. On my controller I see all artists that are in my tags as Artist, in Now Playing and playlists.

It however only addresses part of the inconsistencies in handling artists.
In module Queries.pm there are several queries, that fetch track and album data.

Most of those use tags 'gald', which means only the main artist, album, genre, and duration are fetched from the database. These are cursonginfoQuery, playlistXQuery, playlistTracksQuery, asnd titlesQuery.
Only statusQuery, and addJiveSong use 'aAlKNcx'. Only here the full list of artists (via the A tag) is fetched. The bug that I submitted was about the latter tags and queries, because originally the order of A and a was reversed, so that the contributors info was overwritten by the main artist.

If you see only one artist, then the list or display is possibly using one of the other queries.
Comment 17 Michael Herger 2014-08-05 19:49:50 UTC
I think that's fixed.