Bug 1654 - No Album displayed in now playing on Squeezebox
: No Album displayed in now playing on Squeezebox
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Formats
: 6.1.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-06-10 08:35 UTC by James Craig
Modified: 2008-08-18 10:54 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
return undef for any info elements with a No... string (467 bytes, patch)
2005-06-10 13:22 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2005-06-10 08:35:39 UTC
My Squeezebox display format is
TRACK by ARTIST from ALBUM
I've noticed for a while now that mp3s with no album tag defined show
... from No Album
on the display - isn't this supposed to be removed if the album is blank?

Library scanned from iTunes and I *think* it's all working OK at the web interface.
Comment 1 KDF 2005-06-10 13:22:03 UTC
Created attachment 543 [details]
return undef for any info elements with a No... string

check if the string for NO_$element exists and return undef if the item matches
the string.

May not be needed after Dan/Moser's rework of the infoFormat()
Comment 2 James Craig 2005-06-10 15:25:49 UTC
Yes that does it - thanks KDF!
Comment 3 KDF 2005-06-10 22:41:23 UTC
great.  I just need the ok from Dan to merge it.  I dont want this to get in the
way if the infoFormat changes make this patch useless.
Comment 4 Blackketter Dean 2005-06-11 08:08:14 UTC
Looks good to me.  Go for it!
Comment 5 KDF 2005-06-11 10:56:43 UTC
committed to trunk at change 3374
Comment 6 Chris Owens 2008-03-11 11:28:21 UTC
This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!