Bugzilla – Bug 1644
firmware update clears current playlist
Last modified: 2008-08-18 10:54:16 UTC
and it shouldn't. Proposed patch. Vidur, can you review? --- server/Slim/Player/Squeezebox2.pm (revision 3349) +++ server/Slim/Player/Squeezebox2.pm (working copy) @@ -272,7 +272,7 @@ my $parts = shift; my $transition = shift || 'c'; my $param = shift || 0; - +bt(); if ($client->opened()) { # for now, we'll send a visu packet with each screen update. $client->visualizer(); Index: server/Slim/Player/Playlist.pm =============================================================== ==== --- server/Slim/Player/Playlist.pm (revision 3349) +++ server/Slim/Player/Playlist.pm (working copy) @@ -258,16 +258,6 @@ refreshPlaylist($client); } -sub forgetClient { - my $client = shift; - - # clear out the playlist - Slim::Control::Command::execute($client, ["playlist", "clear"]); - - # trying to play will close out any open files. - Slim::Control::Command::execute($client, ["play"]); -} -
The playlist is also cleared when switching to SqueezeNetwork and back. Might this be related?
Almost certainly. Whoops, that patch was bogus, this is the one to review: Index: Slim/Player/Client.pm =============================================================== ==== --- Slim/Player/Client.pm (revision 3349) +++ Slim/Player/Client.pm (working copy) @@ -878,7 +878,6 @@ if ($client) { Slim::Web::HTTP::forgetClient($client); - Slim::Player::Playlist::forgetClient($client); Slim::Utils::Timers::forgetClient($client); delete $clientHash{$client->id()}; } Index: Slim/Player/Playlist.pm =============================================================== ==== --- Slim/Player/Playlist.pm (revision 3349) +++ Slim/Player/Playlist.pm (working copy) @@ -258,16 +258,6 @@ refreshPlaylist($client); } -sub forgetClient { - my $client = shift; - - # clear out the playlist - Slim::Control::Command::execute($client, ["playlist", "clear"]); - - # trying to play will close out any open files. - Slim::Control::Command::execute($client, ["play"]); -} -
It does indeed. Applied the change. Now I can switch to SQN forth and back without losing the playlist.
Applied in change 3354
This bug was marked resolved in Slimserver 6.1, which is several versions ago. If you're still seeing this bug, please re-open it. Thanks!