Bug 16427 - new delivery of MyApps: not all apps are flagged with isApp from server
: new delivery of MyApps: not all apps are flagged with isApp from server
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: SB Server
: 7.5.x
: PC Other
: P3 normal (vote)
: 7.6.0
Assigned To: Bradley D. Wall
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-02 09:05 UTC by Ben Klaas
Modified: 2011-05-23 09:46 UTC (History)
2 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2010-08-02 09:05:15 UTC
In order to support add/remove/reorder on the client side for MyApps, I added code in r9004 to create a jive.ui.HomeMenu driven MyApps menu.

old way:

one item in home menu that sent a callback to the server for 'myapps items'
thus, resulting menu is a "slimbrowse" menu, and thus not workable for the add/remove/reorder CustomHomeMenu code.

new way:

server sends an isApp flag to all items coming from OPMLBased.pm.
client adds a myapps node to the home menu, and suppresses the old-style myapps home menu item
all home menu items that come in via menustatus and have isApp == 1 get dropped into the new myapps node

problem:
not all apps are sending home menu items through OPMLBased.pm (presumably because not all apps are opml based?). Case in point: Podcast Player

Andy, I'm going to need your help fixing this one.
Comment 1 SVN Bot 2010-08-02 12:53:12 UTC
 == Auto-comment from SVN commit #9007 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=9007 ==

Bug: 16427
Description: comment out code block that creates new MyApps node and items until all apps are included in this menu
Comment 2 Ben Klaas 2010-08-02 13:46:18 UTC
2 questions:
1. Can I expect all apps, present and future, to be fed through Slim::Plugin::OPMLBased.pm?
2. Are there apps, e.g. BBC, Podcast Player, that are only fed from mysb.com? 

If yes to both questions, this is probably just a matter of getting mysb.com updated with the code to send the isApp flag.
Comment 3 SVN Bot 2010-08-03 13:16:40 UTC
 == Auto-comment from SVN commit #31153 to the slim repo by bklaas ==
 == http://svn.slimdevices.com/slim?view=revision&revision=31153 ==

Bug: 16427
Description: opml_generic items need an isApp = 1 flag
Comment 4 SVN Bot 2010-08-03 13:20:48 UTC
 == Auto-comment from SVN commit #9016 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=9016 ==

Fixed Bug: 16427
Description: add back the new My Apps treatment now that r31153 fixes the missing My Apps items
Comment 5 SVN Bot 2010-08-03 13:48:51 UTC
 == Auto-comment from SVN commit #31157 to the slim repo by bklaas ==
 == http://svn.slimdevices.com/slim?view=revision&revision=31157 ==

Bug: 16427
Description: for clarity, send the isApp flag only from Slim::Control::Jive::appMenus
Comment 6 Mickey Gee 2011-05-23 09:46:42 UTC
Verify: Go to My Apps and bring them up to Home menu. PQA has verified this. Podcast player works too.