Bug 1642 - spectrum analyzer screensaver pushes on but doesn't push off
: spectrum analyzer screensaver pushes on but doesn't push off
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Audio
: 6.1.0
: Macintosh All
: P2 normal (vote)
: ---
Assigned To: Adrian Smith
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-06-07 13:33 UTC by Blackketter Dean
Modified: 2008-08-18 10:54 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2005-06-07 13:33:29 UTC
the name of the track just disappears.
Comment 1 Blackketter Dean 2005-06-07 13:39:16 UTC
It just flashes off.
Comment 2 Blackketter Dean 2005-06-07 13:56:21 UTC
Adrian:  What appears to be happening is that a display frame is being sent to the player at the end of 
the client side animation.  And since the lines routine for the screensaver is blank a blank frame is sent. 
It seems unnecessary to send an update frame to the player at the end of the animation.  Is there a 
simple fix for this?
Comment 3 Adrian Smith 2005-06-07 14:21:02 UTC
Dean: yes end animation causes a new render to see if scrolling is needed, so 
this could cause this.  The intention is to supress sending the new update 
frame as it is unchanged [see latest patch.]

I think the screensaver could block updates by setting updateMode to avoid 
this.  I'll look at a patch.
Comment 4 Adrian Smith 2005-06-07 14:55:53 UTC
Dean - Unfortunately this is not as easy as I first though as the update mode 
is cleared during endAnimation to ensure that scrolling will start.

Two options:
1) modify screensaver to return the appropriate value for lines all the time
2) add a flag for pushLeft/Right to avoid the follow on update and render 
which could start scrolling [needs additional server code]

Do you have a view of the preferred option?
Comment 5 Blackketter Dean 2005-06-07 15:09:40 UTC
Option 1 is the cleanest, but please consider finding a way for the termination of a animation to not 
force an unnecessary update to the player.  (the animations should end with the current information on 
the screen and the traffic to the player is redundant.)  Is it possible to start the timer for the scrolling 
without sending a new frame to the client?
Comment 6 Blackketter Dean 2005-06-07 17:18:04 UTC
patch from triode applied.   this will need to get moved to SN too.
Comment 7 Adrian Smith 2005-06-08 12:22:39 UTC
Just to clarify what this does for the bug record:
The patch Dean applied in r3352, causes the cached lines result from the 
previous render to be used during the check for whether scrolling is 
necessary.  This avoids this bug by meaning that the screensaver lines are not 
called.

In current 6.1 the outstanding issue is that an additional display frame is 
sent to the player at the time scrolling is checked.  This will be suppressed 
in future code (it is in my new code which merges graphics and text code.)

Dean - I assume we mark this as fixed?
Comment 8 Chris Owens 2008-03-11 11:28:19 UTC
This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!