Bug 16406 - alarm_snooze_seconds from mysb.com incorrect
: alarm_snooze_seconds from mysb.com incorrect
Status: RESOLVED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Applet
: 7.5.x
: PC Other
: P1 normal (vote)
: 7.5.1
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-27 14:24 UTC by Ben Klaas
Modified: 2010-07-28 11:38 UTC (History)
4 users (show)

See Also:
Category: Bug


Attachments
hack fix to hard code snooze to 9 minutes when playerstatus reports something > 60 minutes (812 bytes, patch)
2010-07-27 14:43 UTC, Ben Klaas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2010-07-27 14:24:51 UTC
when connected to mysb.com:
20100727 21:12:45.389 WARN squeezebox.player - Player.lua:1201 Playerstatus says that the server-side configured snooze time is: 154320832 secs
when connected to SBS:
20100727 21:13:15.685 WARN squeezebox.player - Player.lua:1201 Playerstatus says that the server-side configured snooze time is: 540 secs

Default should be 540 seconds. I've been able to reproduce this with two different players (a radio and a desktop SP) connected to mysb.com

The implications are actually less bad than you might expect. This really only affects a user if they have a server-side alarm, hit snooze, and then the server goes down between that snooze and when the returned alarm should fire. If the server is up through the snooze the bug will have no effect.

Nevertheless, this is not a good bug.

I could hack a fix on the client side where alarm_snooze_seconds is brought down to 540 seconds (nine minutes, industry standard for snooze) if the number is something huge. But it'd be better to find out why that data is so wrong.

Andy, I'm assigning this to you first for comment...
Comment 1 Ben Klaas 2010-07-27 14:43:53 UTC
Created attachment 6920 [details]
hack fix to hard code snooze to 9 minutes when playerstatus reports something > 60 minutes

we should discuss whether to have this in place as a defensive measure
Comment 2 Andy Grundman 2010-07-28 11:38:06 UTC
Fixed, on SN this was being returned as an array ref.