Bugzilla – Bug 16307
protect method calls in NetworkThread.notify
Last modified: 2011-05-18 15:33:30 UTC
Created attachment 6886 [details] use pcall() to send protected calls to applet notification methods This was discovered while looking for the root cause of bug 16303 NetworkThread's notify method should not be making unprotected method calls to applets. Instead encapsulate them with a pcall() so if one applet method fails the rest don't fail. This has been subjected to basic tests and appears to do exactly as specified, and method args are passing through with Lua's '...' correctly.
Created attachment 6887 [details] use pcall() to send protected calls to applet notification methods updated patch with better error logging
Correspondence from Richard Titmuss on the issue: "[Patch] Looks good. I think the reason is historical, NetworkThread was part of the first code Fred wrote, long before we learned of the advantages of pcall :). I'm surprised it's taken so long to expose the problem!"
== Auto-comment from SVN commit #8902 to the jive repo by bklaas == == http://svn.slimdevices.com/jive?view=revision&revision=8902 == Fixed Bug: 16307 Description: Encapsulate calls to notify_* methods in applets in pcall()s so one failure doesn't kill all the rest of the applet method calls.
Since these are fixed, they must not be patch_waiting after all
Closing due to fix