Bug 1627 - RSS blocks on DNS failure
: RSS blocks on DNS failure
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugin
: 6.1.0
: PC RedHat Linux
: P2 normal (vote)
: ---
Assigned To: Andy Grundman
:
Depends on: 3309
Blocks:
  Show dependency treegraph
 
Reported: 2005-06-03 03:12 UTC by Morgan
Modified: 2009-09-08 09:16 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
test for info on server crash (2.04 KB, text/plain)
2005-06-08 09:13 UTC, KDF
Details
log from my setup (27.78 KB, application/octet-stream)
2005-06-08 09:18 UTC, KDF
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Morgan 2005-06-03 03:12:45 UTC
Several days ago I had a DSL issue where my router could not connect to Verizon.
 While in this state, SlimServer choked, freezing me out of the Web Interface
and choking on playback.  Turns out that the RSS feed was blocking when
attempting to read latest headlines.  When trying to retrve RSS feed, it seems
to hang on DNS resolution, essentially freezing the whole Slim Server app for
the duration.  Suggest decoupling the RSS feed from the main thread, or
introducing non-blocking IO scheme.

Thanks as always.
Comment 1 Blackketter Dean 2005-06-03 14:27:04 UTC
Dan, is there a non-blocking DNS that's readily available?
Comment 2 Dan Sully 2005-06-08 07:59:06 UTC
Yes - but it relies on compiled code: http://dotat.at/prog/adns-perl/
Comment 3 KDF 2005-06-08 09:13:58 UTC
Created attachment 537 [details]
test for info on server crash

Slim::Player::Playlist::setCommandExecuteCallback (and clear...) are going to
be removed after 6.1 so changed them to use
Slim::Control::Command::setExecuteCallback (and clear...)
Comment 4 KDF 2005-06-08 09:18:08 UTC
Created attachment 538 [details]
log from my setup

This is the log from startup on win2k wiht slimserver 6.1, slimscrobbler 0.30. 
I've done a slight tweak to get contact through the proxy.  The http comms seem
to work to a certain point, then fail.	I have no idea what that last symbol
reference is in the dump before the crash.
Comment 5 KDF 2005-06-08 09:19:05 UTC
darn...nm those two attachments. for bug 1634 instead
Comment 6 Blackketter Dean 2005-06-13 22:14:27 UTC
This probably won't make it for 6.1, but we'll get to it as soon as feasible.
Comment 7 Andy Grundman 2006-04-26 12:01:05 UTC
The port to SimpleAsyncHTTP will solve this issue, changing target to 6.3.
Comment 8 Andy Grundman 2006-04-28 17:41:06 UTC
Fixed, the new RssNews plugin uses SimpleAsyncHTTP which does non-blocking DNS lookups.
Comment 9 Chris Owens 2006-06-12 14:40:51 UTC
Verified fixed in SlimServer Version: 6.3.0 - 7895 - Windows XP - EN - cp1252
Comment 10 Chris Owens 2006-06-27 14:21:14 UTC
This bug fix is now part of a released version, and so has been marked closed. If you are still experiencing this problem, please reopen the bug.