Bug 1621 - Songs added in reverse order when using All Albums
: Songs added in reverse order when using All Albums
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.1.0
: All Linux (other)
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-05-27 01:59 UTC by Daniel Born
Modified: 2008-08-18 10:54 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
use supplied type instead of hardcoded 'contributor'\ (446 bytes, patch)
2005-06-20 22:01 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Born 2005-05-27 01:59:05 UTC
I'm running slimserver 6.1 nightly from 05/24
I went to softsqueeze and did a search for artist.
I searched for "arioli" which returned 3 artists:
Susie Arioli Band
Susie Arioli Swing Band and
Susie Arioli Swing Band featuring Jordan Officer

Each of these have 1 album each.

From there, I went to All Albums (4th choice after the 3 artists) and 
pressed "Play".

This added all songs for all 3 artists but in reverse order!
(15, 14, 13, 12, ..., 1, 13, 12, 11, ..., 1, 14, 13, 12, ..., 1)
Comment 1 Dan Sully 2005-06-13 22:07:49 UTC
This has been fixed in the 6.1 tree as of subversion change 3391.
Comment 2 Daniel Born 2005-06-19 07:02:23 UTC
Problem still exists in version 6.1 nightly of (06/18).
Comment 3 KDF 2005-06-20 01:43:19 UTC
The change stated to fix this seem to be web UI, but I guess it is not fixed in
the player UI.  Command.pm has a line to choose a sort type when loading tracks
at line 1855: 
	# default to a sort
	$sort ||= exists $find{'album'} ? 'tracknum' : 'track';

If I had more time to test, I could maybe figure out what was going wrong here,
or at least prove that this is the line causing the problem or not.
Comment 4 KDF 2005-06-20 22:01:44 UTC
Created attachment 557 [details]
use supplied type instead of hardcoded 'contributor'\

This should fix it.  The search option sends 'track' as the param for search,
yet the fieldinfo in pages is hardcoded to 'contributor' so the sorting was
being done by artist instead of 'track'.  This patch uses the supplied type,
just like change 3391 did for album search.
Comment 5 KDF 2005-06-22 00:26:58 UTC
committed to trunk at change 3497.
reopen with more details if this problem occurs in some other way.
Comment 6 Chris Owens 2008-03-11 11:28:19 UTC
This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!