Bug 16201 - Same artwork for all albums by same artist
: Same artwork for all albums by same artist
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Artwork
: 7.6.0
: PC Windows XP
: P3 normal with 1 vote (vote)
: 7.6.1
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-08 00:37 UTC by sbjaerum
Modified: 2011-08-14 14:10 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sbjaerum 2010-05-08 00:37:41 UTC
My library consists of album FLACs with embedded cue sheets.
Album artwork is located in same directory as the FLAC files using the format %ARTIST-ALBUM.
There is a bug in the artwork handling so that all albums by an artist are assigned the same artist. As an example, all my Springsteen albums get the Born to Run artwork.
I don't know if this is a bug specific to FLAC+embedded cue sheet, or if it is a generic problem affecting all file types.

I am running 7.6.0-30726 on WinXP.
Comment 1 sbjaerum 2011-06-17 10:00:17 UTC
As of r32523, this bug is still present.

I understand that this bug is not your highest priority, but for me it is an important setback from 7.5 to 7.6.
I suspect that it is not a huge task to fix this bug. So could you help out a long time loyal Squeeze user?

Let me know how I can help with example files etc.
Comment 2 Jim McAtee 2011-06-17 19:29:33 UTC
I just did some testing of this with my library of separate Flac files, no embedded CUE sheets, and I see the same thing. It's not a Flac+embedded CUE sheet thing.

If I set %ARTIST-ALBUM as the artwork file title format, and the albums are kept in separate individual directories, then it all works fine. 

But if all of the tracks and artwork for the albums reside in the same directory, then they all end up with the same cover.

It appears not to be the first image file in the directory alphabetically, but instead the cover from the first album/track in the directory.
Comment 3 sbjaerum 2011-06-19 03:49:00 UTC
Jim, that was useful information.
For me it was good to learn that this problem is not directly related to the cue sheet approach for archiving albums in FLAC format.
Because it affects all formats, it should be straight forward to reproduce and also hopefully increase the motivation for fixing it:)


As a side note, because I have one (large) file per album for the audio and one file for the artwork, each album consists of only two files in my library. I therefore store all albums by one artist in the same directory. The total number of files in each directory is still quite limited. This storage strategy causes this bug to affect my library.
Comment 4 sbjaerum 2011-08-05 10:34:30 UTC
I have noticed that you have committed various artwork fixes lately.
Could you please consider to fix this bug too?
Comment 5 Wolfgang Baltes 2011-08-05 11:01:47 UTC
(In reply to comment #2)
> I just did some testing of this with my library of separate Flac files, no
> embedded CUE sheets, and I see the same thing. It's not a Flac+embedded CUE
> sheet thing.
> 
> If I set %ARTIST-ALBUM as the artwork file title format, and the albums are
> kept in separate individual directories, then it all works fine. 
> 
> But if all of the tracks and artwork for the albums reside in the same
> directory, then they all end up with the same cover.
> 
> It appears not to be the first image file in the directory alphabetically, but
> instead the cover from the first album/track in the directory.

I see the same problem. Any idea when this will be fixed?
Comment 6 Andy Grundman 2011-08-05 11:14:43 UTC
Sorry we missed this one for 7.6.
Comment 7 Andy Grundman 2011-08-12 09:37:26 UTC
I think this may have been fixed, can you please retest with the latest 7.6.1 nightly? When I was fixing the %FILE format I also removed some caching that was probably the cause of this bug.
Comment 8 Jim McAtee 2011-08-12 10:02:19 UTC
I ran the same test as described above in comment 2 and YES, it fixes the problem that I saw.
Comment 9 Wolfgang Baltes 2011-08-12 10:13:26 UTC
(In reply to comment #7)
> I think this may have been fixed, can you please retest with the latest 7.6.1
> nightly? When I was fixing the %FILE format I also removed some caching that
> was probably the cause of this bug.

I loaded nightly build 33068 and rescanned the library. All the artwork is there and it plays the music too!!! Thanks very much for fixing this. Your work is greatly appreciated.

By the way, the scan for 413 albums took 10'42" to scan, where it took only 3'34" with 7.5.3. That's quite a change, but not a big deal for me.
Comment 10 Andy Grundman 2011-08-12 10:30:15 UTC
Great, marking this fixed. Thanks for testing. I think we'll worry about performance after 7.6.1.
Comment 11 sbjaerum 2011-08-14 14:10:14 UTC
Thanks a lot for fixing this!