Bugzilla – Bug 16132
wrong link to http://127.0.0.1:9000/music//cover.jpg
Last modified: 2011-04-29 16:14:16 UTC
In 7.6.0 r30685 once again the link to the default cover art in the web UI is broken. If there is no cover in database, cover is linked to http://127.0.0.1:9000/music//cover.jpg resulting in a "red cross"-picture.
== Auto-comment from SVN commit #30690 to the slim repo by kdf == == http://svn.slimdevices.com/slim?view=revision&revision=30690 == Bug: 16132 Description: (temporary fix) fallback to an id of 0 in the cover art link when there is no itemobj.id to make a proper image link
so the fix should be in 7.5.1 nightlies. 7.6 seems to be non-writeable at the moment, so that will have to wait until it is merged by internal staff.
Kevin - you consider your change a temporary fix. What is missing to make it permanent?
I was thinking the 'proper' fix was to ensure that the itemobj.id would be populated with 0 rather than using the template. In most other cases, the artwork doesn't use ||0 in the templates. I was hoping that I would be able to track down the change that made the template no longer valid, since it has not been altered in a very long time. If the itemobj is intended to have an unpopulated id then perhaps this fix is the right one.
Andy - should we have an id of 0 in case there's no artwork? Or should the artwork handler take care of this?
The remaining work can be targeted for 7.6.0
== Auto-comment from SVN commit #31757 to the slim repo by mherger == == http://svn.slimdevices.com/slim?view=revision&revision=31757 == Fixed Bug: 16132 Description: we don't always have a cover art ID in our data. Fall back to default artwork in those cases.
I now see the generic album art at: /music/0/cover.jpg 7.6.0 r32376