Bug 16095 – Scanner fails for some FLAC+CUE files

Bug 16095 - Scanner fails for some FLAC+CUE files

Summary:

Scanner fails for some FLAC+CUE files

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Scanner
Version:	7.6.0
Platform:	PC Windows XP

Importance:	P1 normal (vote)
Target Milestone:	7.5.1
Assigned To:	Andy Grundman

URL:
Keywords:	Audio::Scan

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-04-19 13:30 UTC by sbjaerum
Modified:	2011-05-12 14:02 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description sbjaerum 2010-04-19 13:30:14 UTC

Some of my FLAC files with embedded CUE sheets fail to be scanned.
An example of the log error message is given below.
I am using 7.6.0 - r30665 on WinXP.

[10-04-19 17:45:08.2031] Slim::Formats::readTags (178) Error: While trying to ->getTag(E:\audio\flac\R\Red_Hot_Chili_Peppers\Red_Hot_Chili_Peppers-Blood_Sugar_Sex_Magik-1991.flac) : buffer_append_space: alloc 24058184 too large (max 20971520) at /<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Formats/FLAC.pm line 912.
[10-04-19 17:45:08.2426] Slim::Formats::readTags (178) Backtrace:

   frame 0: Slim::Utils::Log::logBacktrace (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Formats.pm line 178)
   frame 1: Slim::Formats::readTags (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Schema.pm line 1485)
   frame 2: Slim::Schema::_newTrack (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Schema.pm line 1813)
   frame 3: Slim::Schema::updateOrCreateBase (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Utils/Scanner/Local.pm line 610)
   frame 4: Slim::Utils::Scanner::Local::__ANON__ (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Utils/Scanner/Local.pm line 670)
   frame 5: Slim::Utils::Scanner::Local::new (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Utils/Scanner/Local.pm line 289)
   frame 6: Slim::Utils::Scanner::Local::__ANON__ (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Utils/Scanner/Local.pm line 305)
   frame 7: Slim::Utils::Scanner::Local::__ANON__ (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Utils/Scanner/Local/Async.pm line 84)
   frame 8: Slim::Utils::Scanner::Local::Async::__ANON__ (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Utils/Scanner/Local/Async.pm line 157)
   frame 9: Slim::Utils::Scanner::Local::Async::find (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Utils/Scanner/Local.pm line 96)
   frame 10: Slim::Utils::Scanner::Local::find (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Utils/Scanner/Local.pm line 385)
   frame 11: Slim::Utils::Scanner::Local::rescan (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Music/MusicFolderScan.pm line 79)
   frame 12: Slim::Music::MusicFolderScan::startScan (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Music/Import.pm line 471)
   frame 13: Slim::Music::Import::runImporter (/<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Music/Import.pm line 300)
   frame 14: Slim::Music::Import::runScan (scanner.pl line 339)
   frame 15: (eval) (scanner.pl line 333)
   frame 16: main::main (scanner.pl line 530)

[10-04-19 17:45:08.2578] Slim::Utils::Scanner::Local::__ANON__ (619) ERROR SCANNING file:///E:/audio/flac/R/Red_Hot_Chili_Peppers/Red_Hot_Chili_Peppers-Blood_Sugar_Sex_Magik-1991.flac: Unable to read tags from file

Comment 1 Andy Grundman 2010-04-25 12:02:41 UTC

Thanks, I need the file though to reproduce.

Comment 2 sbjaerum 2010-04-26 10:24:35 UTC

I have uploaded the file to FTP server at hybridized.org as you advised in bug 11950.

Comment 3 Andy Grundman 2010-04-26 16:25:15 UTC

Thanks, I see the problem, some strange off-by-one error that only occurs on Windows and only in filehandle mode...

Comment 4 Andy Grundman 2010-04-26 18:33:54 UTC

Fixed, will be in Audio::Scan 0.79.

Comment 5 sbjaerum 2010-04-27 03:50:17 UTC

Great. Looking forward to test.
To be picky, you have referenced bug 11950 in the comment in the source code patch. I believe you should reference this bug, 16095.

Comment 6 Bradley D. Wall 2011-05-12 14:02:59 UTC

Confirmed fixed in build 7.6.0, build 32398