Bug 1609 - execute method crash on startup
: execute method crash on startup
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Misc
: 6.1.0
: All All
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-05-25 08:00 UTC by KDF
Modified: 2008-08-18 10:54 UTC (History)
0 users

See Also:
Category: ---


Attachments
dont' call if client doesn't exist (494 bytes, patch)
2005-05-25 08:37 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2005-05-25 08:00:08 UTC
not every time, only some startups.

I added a bt() in Stdio.pm before line 250.  It seems that this sometimes gets
here before any clients have initialised.


2005-05-25 07:41:56.1417 Backtrace:

   frame 0: Slim::Control::Stdio::executeCmd
(/Users/fishbone/server/slimserver/Slim/Control/CLI.pm line 233)
   frame 1: Slim::Control::CLI::executeCmd
(/Users/fishbone/server/slimserver/Slim/Control/CLI.pm line 178)
   frame 2: Slim::Control::CLI::processRequest
(/Users/fishbone/server/slimserver/Slim/Networking/Select.pm line 115)
   frame 3: Slim::Networking::Select::select (./slimserver.pl line 625)
   frame 4: main::idle (./slimserver.pl line 568)
   frame 5: main::main (./slimserver.pl line 1155)

Can't call method "execute" on an undefined value at
/Users/fishbone/server/slimserver/Slim/Control/Stdio.pm line 250, <GEN5> line 1.
Comment 1 KDF 2005-05-25 08:37:36 UTC
Created attachment 525 [details]
dont' call if client doesn't exist

this simply doesnt' make the execute call unless the client exists.
Comment 2 Blackketter Dean 2005-05-25 08:43:28 UTC
Actually it is valid to call execute for commands that don't have a valid client. 

Better to call the global function (rather than the client method) for CLI and HTTP execute commands 
(there may be others.)
Comment 3 Dan Sully 2005-05-25 08:53:40 UTC
Fixed in subversion change 3293.
Comment 4 Chris Owens 2008-03-11 11:28:18 UTC
This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!