Bug 16078 – SSH setup doesn't work any more after device had been running for a while

Bug 16078 - SSH setup doesn't work any more after device had been running for a while

Summary:

SSH setup doesn't work any more after device had been running for a while

Status:	REOPENED

Product:	SB Touch
Classification:	Unclassified
Component:	Settings
Version:	7.5.0
Platform:	Macintosh Linux (other)

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Felix Mueller

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-04-16 02:21 UTC by Michael Herger
Modified:	2011-01-14 00:38 UTC (History)
CC List:	3 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Herger 2010-04-16 02:21:35 UTC

Most likely it's running out of memory, trying to get information using some external tool:

Apr 16 11:11:52 squeezeplay: INFO   squeezeplay.applets - AppletMeta.lua:146 entering SetupSSH
Apr 16 11:11:53 squeezeplay: WARN   squeezeplay.ui.draw - jiveL_dispatch_event:774 error in event function:
Apr 16 11:11:53 squeezeplay:    /usr/share/jive/jive/net/Networking.lua:367: attempt to index local 'cmd' (a nil value)
Apr 16 11:11:53 squeezeplay: stack traceback:
Apr 16 11:11:53 squeezeplay:    /usr/share/jive/jive/net/Networking.lua:367: in function 'getIP'
Apr 16 11:11:53 squeezeplay:    /usr/share/jive/applets/SetupSSH/SetupSSHApplet.lua:102: in function '_getIPAddress'
Apr 16 11:11:53 squeezeplay:    /usr/share/jive/applets/SetupSSH/SetupSSHApplet.lua:62: in function '_enableSSH'
Apr 16 11:11:53 squeezeplay:    /usr/share/jive/applets/SetupSSH/SetupSSHApplet.lua:41: in function 'closure'
Apr 16 11:11:53 squeezeplay:    /usr/share/jive/jive/ui/Checkbox.lua:99:

We need to at least sanity check the cmd value. In the long run we should try to get rid of calls to external tools wherever possible. And reduce overall memory consumption.

Comment 1 Felix Mueller 2010-07-18 01:41:09 UTC

This has been fixed with 7.6 r8923 - Getting the current IP address no longer relies on external shell commands.

Comment 2 Michael Herger 2010-07-19 00:09:35 UTC

Thanks Felix. But I wouldn't consider this fixed, as there are still many calls to external tools using os.execute() or io.popen(). 

Whether it's a P2 for 7.6 one might discuss. Or even whether it'll ever get enough P to be fixed :-/.

Comment 3 Felix Mueller 2010-07-19 07:16:54 UTC

You are absolutely correct, Michael. Thanks for double-checking.