Bug 16060 - New & changed scan doesn't clean up genres
: New & changed scan doesn't clean up genres
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.6.0
: PC Windows XP
: P2 normal with 4 votes (vote)
: 7.6.1
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-13 18:07 UTC by Jim McAtee
Modified: 2011-11-05 10:40 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2010-04-13 18:07:20 UTC
This is probably true of all: contributors, albums, years, genres.  If you edit tags in your library so that you effectively remove a genre (fix a misspelling, for example) a 'new & changed' scan in 7.6.0 will fail to remove the genre from the genres table.

I haven't tried it recently in 7.5.x to see if the behavior is different, but if it would help I can do that.
Comment 1 Jim McAtee 2010-04-13 18:23:05 UTC
To answer that last question... Yes, a 'new & changed' scan in 7.5 trunk removes the dead genre.
Comment 2 Jim McAtee 2011-04-07 13:08:51 UTC
Andy, was this inadvertently marked fixed?
Comment 3 Andy Grundman 2011-04-07 13:11:00 UTC
No, I believe this is fixed in 7.6.
Comment 4 Jim McAtee 2011-04-07 13:51:56 UTC
No, it's still present in both 7.6 trunk and onebrowser.
Comment 5 audiomuze 2011-05-17 14:02:11 UTC
Definitely not fixed in 7.6
Comment 6 Jim McAtee 2011-07-08 12:54:22 UTC
I did a bit more testing today and this bug appears to only affect genres. Orphaned artists, albums and years are cleaned up correctly during a new & changed scan.
Comment 7 michael123 2011-07-09 11:24:55 UTC
Not just genres
I've seen also artists
Comment 8 Jim McAtee 2011-08-12 11:01:13 UTC
Is this a difficult fix? I would think you just apply the same logic used for contributors and albums and run a query to do the cleanup.
Comment 9 Andy Grundman 2011-08-12 11:02:07 UTC
I'll look at it, thanks for bringing it up.
Comment 10 SVN Bot 2011-08-14 19:30:17 UTC
 == Auto-comment from SVN commit #33079 to the slim repo by agrundman ==
 == http://svn.slimdevices.com/slim?view=revision&revision=33079 ==

Fixed bug 16060, the code to remove unused genres was broken by the data format coming out of DBI
Comment 11 Uwe Schröder 2011-11-05 10:40:12 UTC
I still see empty albums ... Is this supposed to be fixed in 7.6.2, or only in 7.7?