Bug 16043 - Native ALAC playback broken on Radio
: Native ALAC playback broken on Radio
Status: CLOSED FIXED
Product: SB Radio
Classification: Unclassified
Component: Audio
: Include FW version in comment
: Other Other
: P1 major (vote)
: 7.6.0
Assigned To: Bradley D. Wall
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-12 02:05 UTC by Alan Young
Modified: 2011-05-09 13:25 UTC (History)
5 users (show)

See Also:
Category: Bug


Attachments
Untested patch (911 bytes, patch)
2010-04-19 09:48 UTC, Andy Grundman
Details | Diff
Alternative patch (897 bytes, patch)
2010-04-19 23:46 UTC, Alan Young
Details | Diff
Proposed patch, take 2 (908 bytes, patch)
2010-04-19 23:48 UTC, Alan Young
Details | Diff
Proposed patch, take 3 (1.67 KB, patch)
2010-04-20 03:50 UTC, Alan Young
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2010-04-12 02:05:44 UTC
7.5.0 r8673

Native Apple Lossless playback produces a nasty noise on Squeezebox Radio. 

This should only be invoked when playing ALAC directly from Squeezebox Touch's internal Squeezebox Server, or from some low-powered NAS drives.
Comment 1 Chris Owens 2010-04-16 14:37:29 UTC
To recapitulate a recent bug meeting, Steven asserted that if this can't be fixed that it should be disabled so that the Radio doesn't make noise.

Setting aside the disabling issue for now, is the Radio *supposed* to have native playback of ALAC?  i.e. is it in there and broken, or would we be adding it entirely.
Comment 2 Chris Owens 2010-04-19 09:30:41 UTC
I feel strongly that this needs to be more easily configurable from one SP device to another without complex code and compiler changes.

We will need the flexibility moving forward to have a variety of CPUs in our devices that will necessarily have effects on what codecs can be supported.
Comment 3 Andy Grundman 2010-04-19 09:48:00 UTC
Created attachment 6792 [details]
Untested patch

Alan: looks like each product has its own common.h file, so would it be as simple to fix as this patch?
Comment 4 Alan Young 2010-04-19 23:46:26 UTC
Created attachment 6793 [details]
Alternative patch

Also untested, as yet
Comment 5 Alan Young 2010-04-19 23:48:57 UTC
Created attachment 6794 [details]
Proposed patch, take 2
Comment 6 Alan Young 2010-04-20 03:19:41 UTC
No, that approach does not work. ...baby/common.h is only used for the squeezeplay_baby tree, not the main squeezplay tree where we need the change.
Comment 7 Alan Young 2010-04-20 03:50:46 UTC
Created attachment 6796 [details]
Proposed patch, take 3

This is the sort of thing that we need but I do not understand autotools enough to make it work
Comment 8 Alan Young 2010-04-20 03:51:37 UTC
Update hours
Comment 9 Alan Young 2010-06-08 06:30:33 UTC
It looks like the problem has been fixed by the update to the latest toolchain. This means that a backport to 7.5.X is most unlikely.
Comment 10 Paul Chandler 2011-05-09 13:25:51 UTC
Used radio to playback .m4a files  (7.6.r 32390) fw 9432